engine: free after log worker thread has been stopped#8486
Merged
edsiper merged 1 commit intofluent:masterfrom May 22, 2024
Merged
engine: free after log worker thread has been stopped#8486edsiper merged 1 commit intofluent:masterfrom
edsiper merged 1 commit intofluent:masterfrom
Conversation
Signed-off-by: Hiroyuki Hasebe <31443554+hiroyha1@users.noreply.github.com>
c3cbbb4 to
730054a
Compare
Contributor
Author
|
cc: @edsiper @leonardo-albertovich Could you please review this pr? |
|
@edsiper and @leonardo-albertovich - any update on this review? |
1 similar comment
|
@edsiper and @leonardo-albertovich - any update on this review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current code,
config->log_filemay be referenced in thelog_pushfunction after it is freed. This fix freeslog_fileafter callingflb_log_destroyfunction so that it waits forlog_worker_collectorfunction to exit.Fixes #8429
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
valgrind.log
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.