out_stackdriver: add k8s_cluster resource type#8349
Merged
braydonk merged 2 commits intofluent:masterfrom Jan 23, 2024
Merged
Conversation
Contributor
Author
|
test failure looks like a flake |
braydonk
requested changes
Jan 22, 2024
Contributor
braydonk
left a comment
There was a problem hiding this comment.
The change looks good to me!
Would you mind adding a test for this as well? You can use this other resource test as a reference. I can intuitively see that this will work based on the implementation, so it's just a matter of getting a test for it.
I'll be good to merge it after a test is added!
this can be used in combination with the in_kubernetes_events to write k8s_cluster type events to stackdriver(such as replicaset events) Signed-off-by: ryanohnemus <ryanohnemus@gmail.com>
Signed-off-by: ryanohnemus <ryanohnemus@gmail.com>
180bd3c to
a1cf43e
Compare
Contributor
Author
|
@braydonk, just rebased and pushed with a test. I will watch the CI checks for any failures, but otherwise we should be good to go |
braydonk
approved these changes
Jan 22, 2024
Contributor
braydonk
left a comment
There was a problem hiding this comment.
LGTM, unless something in CI fails I will merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add k8s_cluster resource type to out_stackdriver plugin.
This can be used in combination with the in_kubernetes_events to write k8s_cluster type events to stackdriver (such as any non-Pod based kubernetes events)
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
out_stackdriver: add k8s_cluster resource type fluent-bit-docs#1284
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.