filter_lua: add index to arraylength call #8103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with `FLB_FILTER_LUA_USE_MPACK`, compilation fails because this `flb_lua_arraylength` call didn't have an index argument. This PR passes the index argument to the function that I believe to be correct, which is `-1` (assuming based on its usage in the following loop to get individual elements). Signed-off-by: braydonk <braydonk@google.com>
braydonk
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Contributor
Author
|
Not sure whether backporting is necessary here. |
Contributor
Author
|
@nokute78 requesting review from you since the blame suggests that you added the |
Contributor
Author
|
Thanks @nokute78! Just waiting on an approval from another maintainer to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with
FLB_FILTER_LUA_USE_MPACK, compilation fails because thisflb_lua_arraylengthcall didn't have an index argument. This PR passes the index argument to the function that I believe to be correct, which is-1(assuming based on its usage in the following loop to get individual elements).Didn't make an issue but I can if necessary
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.