build: Fix release builds with enabled FLB_DEBUG [backport 2.1]#8068
Open
Garfield96 wants to merge 1 commit intofluent:2.1from
Open
build: Fix release builds with enabled FLB_DEBUG [backport 2.1]#8068Garfield96 wants to merge 1 commit intofluent:2.1from
Garfield96 wants to merge 1 commit intofluent:2.1from
Conversation
Enabling FLB_RELEASE should enable compiler optimizations. However, if FLB_DEBUG was enabled at the same time, no optimization settings were applied. Now, FLB_RELEASE will always enable optimizations and includes debug information (CMAKE_BUILD_TYPE is RelWithDebInfo). Signed-off-by: Christian Norbert Menges <christian.norbert.menges@sap.com>
Garfield96
requested review from
celalettin1286,
fujimotos,
niedbalski and
patrick-stephens
as code owners
Contributor
|
Seems good. Would you mind if you added a marker for displaying backport on the suffix of PR title? It should be added as: |
patrick-stephens
changed the title
patrick-stephens
approved these changes
Oct 20, 2023
1 task
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8058
Enabling
FLB_RELEASEshould enable compiler optimizations. However, ifFLB_DEBUG(enabled by default) was enabled at the same time, no optimization settings were applied. Now,FLB_RELEASEwill always enable optimizations and includes debug information (CMAKE_BUILD_TYPEisRelWithDebInfo).Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.