in_forward: fix checking return value of cmt_decode_msgpack_create(#8000)#8015
Merged
edsiper merged 1 commit intofluent:masterfrom Oct 17, 2023
Merged
in_forward: fix checking return value of cmt_decode_msgpack_create(#8000)#8015edsiper merged 1 commit intofluent:masterfrom
edsiper merged 1 commit intofluent:masterfrom
Conversation
…uent#8000) Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
nokute78
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
edsiper
pushed a commit
that referenced
this pull request
Oct 17, 2023
) (#8015) Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
This was referenced Oct 17, 2023
edsiper
pushed a commit
that referenced
this pull request
Oct 19, 2023
) (#8015) Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
edsiper
pushed a commit
that referenced
this pull request
Oct 19, 2023
) (#8015) Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
leonardo-albertovich
pushed a commit
that referenced
this pull request
Nov 3, 2023
) (#8015) Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmt_encode_msgpack_createcan return positive error code likeCMT_DECODE_MSGPACK_INVALID_ARGUMENT_ERROR.We should check if the return value is
CMT_DECODE_MSGPACK_SUCCESSor not.#8000 can be caused if the API returns positive error and cmt is invalid pointer.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.