Skip to content

out_chronicle: remove redundant code #8004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edsiper merged 3 commits into from
Oct 17, 2023
Merged

out_chronicle: remove redundant code #8004

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81b1be5
out_chronicle: remove redundant initializations.
lecaros Oct 4, 2023
131e7aa
out_chronicle: remove unnecessary if.
lecaros Oct 4, 2023
953f149
out_chronicle: remove unnecessary variable.
lecaros Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions plugins/out_chronicle/chronicle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,6 @@ static flb_sds_t flb_pack_msgpack_extract_log_key(void *out_context, uint64_t by
int i;
int map_size;
int check = FLB_FALSE;
int found = FLB_FALSE;
int log_key_missing = 0;
int ret;
struct flb_chronicle *ctx = out_context;
Expand Down Expand Up @@ -550,10 +549,6 @@ static flb_sds_t flb_pack_msgpack_extract_log_key(void *out_context, uint64_t by

map_size = map.via.map.size;

/* Reset variables for found log_key and correct type */
found = FLB_FALSE;
check = FLB_FALSE;

/* Extract log_key from record and append to output buffer */
for (i = 0; i < map_size; i++) {
key = map.via.map.ptr[i].key;
Expand All @@ -572,7 +567,6 @@ static flb_sds_t flb_pack_msgpack_extract_log_key(void *out_context, uint64_t by

if (check == FLB_TRUE) {
if (strncmp(ctx->log_key, key_str, key_str_size) == 0) {
found = FLB_TRUE;

/*
* Copy contents of value into buffer. Necessary to copy
Expand Down Expand Up @@ -607,9 +601,7 @@ static flb_sds_t flb_pack_msgpack_extract_log_key(void *out_context, uint64_t by
}

/* If log_key was not found in the current record, mark log key as missing */
if (found == FLB_FALSE) {
log_key_missing++;
}
log_key_missing++;
}

if (log_key_missing > 0) {
Expand Down