log_event_encoder: switched data size type to overcome msvc issue #7971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Alminana <leonardo@calyptia.com>
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
7 tasks
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
Signed-off-by: David Korczynski <david@adalogics.com>
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
…named from 'label'. Signed-off-by: Phillip Whelan <phil@calyptia.com>
Signed-off-by: Phillip Whelan <phil@calyptia.com>
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
added 3 commits
September 26, 2023 15:07
Signed-off-by: Leonardo Alminana <leonardo@calyptia.com>
Signed-off-by: Leonardo Alminana <leonardo@calyptia.com>
Signed-off-by: Leonardo Alminana <leonardo@calyptia.com>
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
Signed-off-by: Leonardo Alminana <leonardo@calyptia.com>
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
Signed-off-by: Leonardo Alminana <leonardo@calyptia.com>
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
deleted the
leonardo-master-log_event_encoder_msvc_fix
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with msvc where it incorrectly saves integer data to the stack when passing data sizes to flb_log_event_encoder_append_body_values_unsafe.