config_format: fix memory leak#7961
Merged
leonardo-albertovich merged 2 commits intofluent:masterfrom Sep 26, 2023
DavidKorczynski:fix-config-yaml-leak
Merged
config_format: fix memory leak#7961leonardo-albertovich merged 2 commits intofluent:masterfrom DavidKorczynski:fix-config-yaml-leak
leonardo-albertovich merged 2 commits intofluent:masterfrom
DavidKorczynski:fix-config-yaml-leak
Conversation
There can be multiple states needing to be popped in the event of errors. Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61733 Signed-off-by: David Korczynski <david@adalogics.com>
DavidKorczynski
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Member
|
not passing CI |
Member
|
cc: @pwhelan |
Signed-off-by: David Korczynski <david@adalogics.com>
Contributor
Author
|
Unit test failing looks unrelated? |
Contributor
The failure in |
pwhelan
approved these changes
Sep 26, 2023
Contributor
pwhelan
left a comment
pwhelan
left a comment
There was a problem hiding this comment.
Looks good to me. It works as intended.
The CI tests failed to an unrelated change which should be fixed in master now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can be multiple states needing to be popped in the event of errors.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61733
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.