Skip to content

Conversation

@pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Sep 20, 2023

Summary

Monkey v1.7.2 includes a fix to pthread_setspecific which fixes a crash in win32 in the co-routines API. This is a blocker for #7929.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Phillip Whelan <[email protected]>
@pwhelan pwhelan temporarily deployed to pr September 20, 2023 15:12 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 20, 2023 15:12 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 20, 2023 15:12 — with GitHub Actions Inactive
@pwhelan pwhelan mentioned this pull request Sep 20, 2023
7 tasks
@pwhelan pwhelan temporarily deployed to pr September 20, 2023 15:40 — with GitHub Actions Inactive
@edsiper
Copy link
Member

edsiper commented Sep 21, 2023

@pwhelan thanks!

one thing: 1.7.2 was not released yet (but I just pushed the tag), ideally we want to make sure that the tag release exists in the other repo otherwise we can be in sync, but all good now.

@edsiper edsiper merged commit 60fc471 into master Sep 21, 2023
@edsiper edsiper deleted the pwhelan-monkey-v172 branch September 21, 2023 04:51
leonardo-albertovich pushed a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants