in_tail: ingestion interruption fix #7815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 9, 2023 18:31
This PR fixes the overtly restrictive file metadata query which if I remember correctly was added to mitigate a performance issue. Signed-off-by: Leonardo Alminana <[email protected]>
…ested This was feature was meant to ignore files whoses modification time exceeds the limit specified in ignore_older, however, when a file is deemed acceptable it should be discarded if the system took more than expected to ingest it. Signed-off-by: Leonardo Alminana <[email protected]>
…ector A side effect of the progress check callback directly ingesting data is that the ingestion rate is capped to the timer frequency multipled by the buffer size. The right approach is to signal the event based pending collector so it continuously runs until the file is completely ingested (which is handled by the controlled consumption of the signal from the channel). Signed-off-by: Leonardo Alminana <[email protected]>
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
patrick-stephens
had a problem deploying
to
integration
GitHub Actions
Failure
patrick-stephens
temporarily deployed
to
integration
GitHub Actions
Inactive
patrick-stephens
temporarily deployed
to
integration
GitHub Actions
Inactive
Member
|
@leonardo-albertovich should we merge this for the active 2.1 or for next 2.2 series in late October ? |
Contributor
Author
|
I'd say 2.1 |
Contributor
|
@edsiper The user didn't confirm, but the behavior is pretty much the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two individual issues :
ignore_olderis set and a file that was deemed viable is being ingested (while no one is appending data to it) fluent-bit will drop the file as soon as the modification time exceeds the limit imposed byignore_older.It's important to keep in mind that point number one has been a long standing default behavior which means changing it could cause disruptions so please, request the change if we need to add a new option to opt-out of the old behavior.