Conversation
cosmo0920
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
cosmo0920
force-pushed
the
cosmo0920-divide-storage-path-for-tests-on-input-chunk-test
branch
from
4e9bf89 to
0e97d2c
Compare
cosmo0920
force-pushed
the
cosmo0920-divide-storage-path-for-tests-on-input-chunk-test
branch
from
0e97d2c to
132f16e
Compare
cosmo0920
changed the title
cosmo0920
force-pushed
the
cosmo0920-divide-storage-path-for-tests-on-input-chunk-test
branch
from
132f16e to
0ee0578
Compare
This is because different storage.paths should be used per test. Sometimes this cause failure for retrieving the file contents to prepare the data for input_chunk test cases: ```log Test input_chunk_exceed_limit... [ FAILED ] input_chunk.c:91: Check getting output file content: ~/GitHub/fluent-bit/tests/internal/data/input_chunk/out/a_thousand_plus_one_bytes.out... failed [2023/07/28 00:03:09] [error] [~/GitHub/fluent-bit/tests/internal/input_chunk.c:56 errno=0] Success ``` After splitting the storage.path per test case, this error won't happen. Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
cosmo0920
force-pushed
the
cosmo0920-divide-storage-path-for-tests-on-input-chunk-test
branch
from
0ee0578 to
d5a4a6e
Compare
edsiper
deleted the
cosmo0920-divide-storage-path-for-tests-on-input-chunk-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because different storage.paths should be used per test. Sometimes this cause failure for retrieving the file contents to prepare the data for test cases:
After splitting the storage.path per test case, this error won't happen.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.