Adds support for Content-Encoding: gzip to in_http#7667
Adds support for Content-Encoding: gzip to in_http#7667edsiper merged 1 commit intofluent:masterfrom
Conversation
|
Valgrind output: Commands I ran to test: non-gzipped: gzipped: Invalid content-encoding header: (this results in no output in the fluent-bit log and returns |
|
No config file is required to test this: I just ran |
|
@erhudy would you please fix the conflict ? |
Reconciled. |
|
@leonardo-albertovich pls review |
|
Anything you need from me on this PR right now? I've had this in production at my company since I made this PR and in almost 4 months it's just been doing the thing I expect it to do. |
cosmo0920
left a comment
There was a problem hiding this comment.
The logic seems good but I added some concerns to proceed the PR.
|
Could you rebase @erhudy as it looks like there were some issues running actions (possibly a Github outage at the time)? |
|
@leonardo-albertovich are you ok with this? |
Rebased. |
|
There we go, got unit tests running now. |
|
@patrick-stephens it looks like 2/3 macOS test suites failed. I don't see an indication that it's related to my changes, but I don't have permission to rerun just those actions. |
|
Added fluent/fluent-bit-docs#1260 for documentation change. |
Currently, macOS tests are flaky. Feel free to ignore them. Instead, please pay attention to Ubuntu unit tests and Windows builds. |
4830228 to
be5a5c9
Compare
Signed-off-by: Edmund Rhudy <erhudy@users.noreply.github.com>
|
thank you! please make sure to adjust commits for further contributions: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes |
Signed-off-by: Edmund Rhudy <erhudy@users.noreply.github.com>
Signed-off-by: Edmund Rhudy <erhudy@users.noreply.github.com>
This change adds support for gzipped content to in_http. I discovered this by accident when attempting to send gzipped JSON from another fluent-bit, and found that fluent-bit responded with an invalid JSON error. With this PR, fluent-bit will now appropriately handle gzipped content on the HTTP input.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.