out_azure_logs_ingestion: fix NULL dereference#7624
Merged
edsiper merged 2 commits intofluent:masterfrom Sep 23, 2023
DavidKorczynski:fix-possible-nullderef
Merged
out_azure_logs_ingestion: fix NULL dereference#7624edsiper merged 2 commits intofluent:masterfrom DavidKorczynski:fix-possible-nullderef
edsiper merged 2 commits intofluent:masterfrom
DavidKorczynski:fix-possible-nullderef
Conversation
The code checks if `ctx` is NULL, and if it is' NULL proceeds to dereference `ctx` by way of `ctx->ins`. As such, there will always be a NULL dereference if the condition `if (!ctx)` is true. This fixes it by removing the dereference. Signed-off-by: David Korczynski <[email protected]>
DavidKorczynski
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
leonardo-albertovich
suggested changes
Jun 30, 2023
Signed-off-by: David Korczynski <[email protected]>
leonardo-albertovich
approved these changes
Aug 8, 2023
leonardo-albertovich
pushed a commit
that referenced
this pull request
Oct 5, 2023
The code checks if `ctx` is NULL, and if it is' NULL proceeds to dereference `ctx` by way of `ctx->ins`. As such, there will always be a NULL dereference if the condition `if (!ctx)` is true. This fixes it by removing the dereference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code checks if
ctxis NULL, and if it is' NULL proceeds to dereferencectxby way ofctx->ins. As such, there will always be a NULL dereference if the conditionif (!ctx)is true. This fixes it by removing the dereference.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.