build: enable in_kafka and out_kafka by default #5204
Conversation
tarruda
force-pushed
the
enable-kafka-plugins-by-default
branch
from
7de7a96 to
696ccd8
Compare
|
@agup006 I've enabled kafka plugins by default, but not on Windows since it causes a build error on CI |
|
What's the build error? |
Looks like it doesn't like some of the void* usage: https://ci.appveyor.com/project/fluent/fluent-bit-2e87g/builds/43155542/job/yyye570bjrb67uvg#L2827 |
tarruda
force-pushed
the
enable-kafka-plugins-by-default
branch
from
39e9e22 to
049ef77
Compare
tarruda
requested review from
edsiper,
koleini and
leonardo-albertovich
as code owners
tarruda
force-pushed
the
enable-kafka-plugins-by-default
branch
from
049ef77 to
f77011b
Compare
|
Fixed the issue with windows build, just replacing |
patrick-stephens
left a comment
patrick-stephens
left a comment
There was a problem hiding this comment.
LGTM @niedbalski
|
FYI: this is blocked until we fix threaded input interface |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@patrick-stephens rebased and fixed the builds. Couldn't enable by default on windows because the build fails on missing |
|
These changes are a hard requirement for this PR to be merged. |
tarruda
force-pushed
the
enable-kafka-plugins-by-default
branch
from
5163388 to
b786be3
Compare
|
@leonardo-albertovich it seems the windows-specific cmake is not being applied during CI since appveyor tried to build it. Do you know what I might have missed? |
Signed-off-by: Thiago Padilha <[email protected]>
tarruda
force-pushed
the
enable-kafka-plugins-by-default
branch
from
b786be3 to
70069f0
Compare
|
@leonardo-albertovich nevermind, it was a typo in windows-setup.cmake. Can you approve again? |
6 participants
close #5189
Signed-off-by: Thiago Padilha [email protected]