Skip to content

tests: runtime: Use long json payloads to trigger rotataion easily - #12215

Merged
edsiper merged 1 commit into
masterfrom
cosmo0920-plug-failing-rotate-test-case-2nd-attempt
Aug 4, 2026
Merged

tests: runtime: Use long json payloads to trigger rotataion easily#12215
edsiper merged 1 commit into
masterfrom
cosmo0920-plug-failing-rotate-test-case-2nd-attempt

Conversation

@cosmo0920

@cosmo0920 cosmo0920 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Using small json payloads could be difficult to trigger file rotation.
So, we need to use long json payloads instead.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Tests
    • Expanded file-rotation test coverage by using larger input payloads.
    • Improved validation of same-second rotations, filename patterns, legacy cleanup, gzip compression, and maximum-file cleanup.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f416e10-5d81-4c54-a820-53ad91ae38ab

📥 Commits

Reviewing files that changed from the base of the PR and between cbe1253 and e80c10c.

📒 Files selected for processing (1)
  • tests/runtime/out_file_rotation.c

📝 Walkthrough

Walkthrough

Five file-rotation tests now use JSON_LONG instead of JSON_SMALL. The tests cover same-second rotation, filename patterns, legacy cleanup, gzip compression, and maximum-file cleanup.

Changes

File rotation payload coverage

Layer / File(s) Summary
Update rotation test payloads
tests/runtime/out_file_rotation.c
The five file-rotation tests now send JSON_LONG payloads.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: edsiper, sagiroosto

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: using longer JSON payloads to make runtime file-rotation tests trigger more easily.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-plug-failing-rotate-test-case-2nd-attempt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@edsiper
edsiper merged commit e589385 into master Aug 4, 2026
57 of 62 checks passed
@edsiper
edsiper deleted the cosmo0920-plug-failing-rotate-test-case-2nd-attempt branch August 4, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants