Skip to content

tests: internal: Plug an uninitialized coro stack - #12214

Merged
edsiper merged 1 commit into
masterfrom
cosmo0920-plug-segv-on-network-test-case
Aug 4, 2026
Merged

tests: internal: Plug an uninitialized coro stack#12214
edsiper merged 1 commit into
masterfrom
cosmo0920-plug-segv-on-network-test-case

Conversation

@cosmo0920

@cosmo0920 cosmo0920 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Without this uninitialized coro stack, this missing line causes SEGV on macOS with flb-it-network.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Bug Fixes
    • Improved coroutine-related test reliability by ensuring the coroutine subsystem is initialized before use.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920
cosmo0920 requested a review from edsiper as a code owner August 4, 2026 04:42
@cosmo0920 cosmo0920 added this to the Fluent Bit v5.1 milestone Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b09e9cec-2d4c-44e9-a406-4f5191645cae

📥 Commits

Reviewing files that changed from the base of the PR and between cbe1253 and 6a2b3af.

📒 Files selected for processing (1)
  • tests/internal/network.c

📝 Walkthrough

Walkthrough

The parent-stack callback test now initializes the coroutine subsystem before it creates and uses coroutine threads.

Changes

Network test coroutine setup

Layer / File(s) Summary
Initialize coroutine support
tests/internal/network.c
The test calls flb_coro_init() before coroutine thread initialization.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: edsiper

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the test change that fixes an uninitialized coroutine stack.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-plug-segv-on-network-test-case

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a2b3afa41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/internal/network.c
@edsiper
edsiper merged commit c98b652 into master Aug 4, 2026
72 of 88 checks passed
@edsiper
edsiper deleted the cosmo0920-plug-segv-on-network-test-case branch August 4, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants