Skip to content

node_exporter_metrics: Add file path to error messages [Backport to 4.2] - #11992

Merged
cosmo0920 merged 3 commits into
4.2from
improve-node-exporter-errors-4.2
Jun 24, 2026
Merged

node_exporter_metrics: Add file path to error messages [Backport to 4.2]#11992
cosmo0920 merged 3 commits into
4.2from
improve-node-exporter-errors-4.2

Conversation

@cosmo0920

Copy link
Copy Markdown
Contributor

Backporting of #11839.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

rossigee added 3 commits June 24, 2026 13:53
Improve error logs to indicate which file path failed when reading
metrics, making it easier to debug missing hardware sensors or
permissions issues.

Signed-off-by: Ross Golder <ross@golder.org>
Signed-off-by: Ross Golder <ross@golder.org>
Signed-off-by: Ross Golder <ross@golder.org>
@cosmo0920
cosmo0920 marked this pull request as ready for review June 24, 2026 04:54
@cosmo0920
cosmo0920 requested a review from edsiper as a code owner June 24, 2026 04:54
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 542dcb11-b338-41f5-892c-88c79d5b096e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-node-exporter-errors-4.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cosmo0920
cosmo0920 merged commit e93d71d into 4.2 Jun 24, 2026
48 of 51 checks passed
@cosmo0920
cosmo0920 deleted the improve-node-exporter-errors-4.2 branch June 24, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants