packaging: add support for Ubuntu 26.04 - #11802
Conversation
📝 WalkthroughWalkthroughThis PR adds Ubuntu 26.04 support across the Fluent Bit packaging infrastructure by registering new build targets, providing Docker build stages for both x86_64 and ARM64v8 architectures, and configuring repository publishing for the resulting Debian packages. ChangesUbuntu 26.04 build and packaging support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e63274eec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
0e63274 to
336d62d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packaging/distros/ubuntu/Dockerfile`:
- Around line 260-282: The Dockerfile stage labeled ubuntu-26.04-base is using
the wrong base image (FROM ubuntu:24.04); update the FROM line for the
ubuntu-26.04-base stage to use the correct ubuntu:26.04 image so the stage name,
comment, and package metadata match the intended distribution. Ensure the change
is made where the stage label ubuntu-26.04-base is declared (near the existing
ARG CMAKE_VERSION/CMAKE_HOME block) and keep the rest of the RUN/install steps
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4d77e71e-22e1-4758-9f4d-66b4ead64cfa
📒 Files selected for processing (3)
packaging/build-config.jsonpackaging/distros/ubuntu/Dockerfilepackaging/update-repos.sh
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packaging/distros/ubuntu/Dockerfile`:
- Line 280: Remove the insecure curl -k option from the CMake download commands
so TLS certificate validation is enforced; update the two curl invocations that
reference "${cmake_download_url}" and extract into "${CMAKE_HOME}" (the lines
using curl -jksSL "${cmake_download_url}" | tar ...) to drop the -k flag (i.e.,
use -jsSL or equivalent) in both occurrences.
- Around line 269-280: The ubuntu-26.04-base and ubuntu-26.04.arm64v8-base
Docker stages run piped commands (e.g., the curl | tar pipeline that uses
CMAKE_HOME and CMAKE_VERSION) but lack a SHELL directive enabling pipefail; add
a SHELL directive for those two stages to run bash with pipefail enabled so that
failures in the curl | tar pipeline (and any other piped commands) surface and
cause the build to fail.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1b1b2a3f-83c1-4fa7-a5dd-b191bbd78b31
📒 Files selected for processing (3)
packaging/build-config.jsonpackaging/distros/ubuntu/Dockerfilepackaging/update-repos.sh
🚧 Files skipped from review as they are similar to previous changes (2)
- packaging/update-repos.sh
- packaging/build-config.json
|
@celalettin1286 / @niedbalski can you approve so can merge? Pretty straightforward I hope! |
Adds support for latest Ubuntu 26.04 LTS version (
resolute).Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit