reload: add a timeout mechanism and its based commits backporting [Backport to 4.0] #10985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alec Holmes <alec@chronosphere.io>
Signed-off-by: Alec Holmes <alec@chronosphere.io>
- Add hot_reload_watchdog_timeout_seconds field to flb_config struct - Add FLB_CONF_STR_HOT_RELOAD_TIMEOUT configuration string - Add parsing logic in service_configs array - Set default timeout to 300 seconds in flb_config_init Signed-off-by: Bradley Laney <bradley.laney@chronosphere.io>
- Add watchdog thread that monitors hot reload duration - Thread sleeps for configured timeout then aborts if reload hasn't completed - Watchdog is started at beginning of reload and cancelled on completion - Uses pthread_cancel with async cancellation for immediate response - Properly cleans up thread resources with pthread_join Signed-off-by: Bradley Laney <bradley.laney@chronosphere.io>
- Add test_hang_on_collect configuration option - When enabled, dummy plugin hangs during collect to simulate stuck reload - Used only for testing hot reload watchdog functionality Signed-off-by: Bradley Laney <bradley.laney@chronosphere.io>
- Add test_reload_watchdog_timeout to verify watchdog functionality - Test forks a child process that triggers reload with hanging dummy input - Verifies that watchdog aborts the process after timeout - Checks that child terminates with SIGABRT signal Signed-off-by: Bradley Laney <bradley.laney@chronosphere.io>
cosmo0920
requested review from
edsiper,
fujimotos,
koleini and
nokute78
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting of #10869, #10826, and #10874.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.