Merged
Conversation
Signed-off-by: Leonardo Alminana <leonardo.alminana@chronosphere.io>
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
brablc
reviewed
Apr 22, 2025
| /* For Logs type, we need to commit the block right away */ | ||
| if (event_type == FLB_EVENT_TYPE_LOGS) { | ||
| ret = azb_block_blob_commit_block(ctx, block_id, tag, ms); | ||
| flb_free(block_id); |
There was a problem hiding this comment.
Isn't it possible, that only removing this line should be enough? Calling flb_free on NULL should not be a problem.
Contributor
Author
There was a problem hiding this comment.
Just removing that line fixes the double free but considering that there are code paths that lead to calling free with block_id holding NULL it's worth adding the check since older systems (and maybe alternative libc implementations?) don't handle it gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a double free in send_blob.