config: yaml: fix double-free from freeing state before cleanup on exit.#10199
Merged
config: yaml: fix double-free from freeing state before cleanup on exit.#10199
Conversation
remove calls to state_destroy on error when it will be cleaned up at the end of the function that parses the yaml configuration. Signed-off-by: Phillip Whelan <phillip.whelan@chronosphere.io>
pwhelan
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Contributor
Author
|
I am attaching here a valgrind.log that also shows memory that |
Member
|
thanks. note that prefix must be: |
nourdouf
pushed a commit
to seveas/fluent-bit
that referenced
this pull request
Sep 23, 2025
…p on exit. (fluent#10199) remove calls to state_destroy on error when it will be cleaned up at the end of the function that parses the yaml configuration. Signed-off-by: Phillip Whelan <phillip.whelan@chronosphere.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix double frees when an error occurs when parsing yaml configuration files, especially with missing include files.
Description
Remove calls to state_destroy on error when it will be cleaned up at the end of the function that parses the yaml configuration.
This fix is meant to address CVE-2025-29477. This is mostly to just encourage code cleanliness.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.