docs: administration: document logs tag records telemetry metrics - #2655
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe documentation describes service and input configuration for per-tag log record metrics. It also documents tracked and untracked input metrics, their labels, cardinality limits, validation rules, and configuration requirements. ChangesTelemetry metrics documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@administration/configuring-fluent-bit/yaml/service-section.md`:
- Around line 51-59: Update the `max_series` and `max_tag_length` entries in the
`telemetry.metrics.logs.tag_records` configuration table to document their
accepted type, minimum value, and startup behavior for invalid values, including
the existing `0` sentinel semantics. State the exact validation rules for both
numeric limits and preserve the current defaults and descriptions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a8c5a4f3-4996-449b-a626-8c8c48f39d36
📒 Files selected for processing (3)
administration/configuring-fluent-bit/yaml/pipeline-section.mdadministration/configuring-fluent-bit/yaml/service-section.mdadministration/monitoring.md
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@patrick-stephens ready for review! |
Document the service-level telemetry.metrics.logs.tag_records block, its per-input enabled override, and the two metrics it exposes: - service-section.md: add a Telemetry configuration section covering enabled, max_series, and max_tag_length, and note that the block is YAML-only with no dotted-key or classic-mode form. - pipeline-section.md: document the per-input enabled override and that the limits are service-level only. - monitoring.md: add fluentbit_input_logs_tag_records_total and fluentbit_input_logs_tag_records_untracked_total, including the max_series, tag_length_limit, and error reason labels. Signed-off-by: Eric D. Schabell <eric@schabell.org>
The max_series and max_tag_length rows documented the 0 sentinel but not the accepted types or what happens on a bad value. - Note that both limits accept an integer or an integer-only string, that strings are environment-variable expanded, and that the value must fit in a signed 32-bit integer. - Document that unparsable or out-of-range values fail at startup. - Correct the sentinel: 0 or less removes the limit. Neither limit enforces a minimum, so negative values are accepted rather than rejected. Signed-off-by: Eric D. Schabell <eric@schabell.org>
2f909b3 to
69be352
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
) * docs: administration: document logs tag records telemetry metrics Document the service-level telemetry.metrics.logs.tag_records block, its per-input enabled override, and the two metrics it exposes: - service-section.md: add a Telemetry configuration section covering enabled, max_series, and max_tag_length, and note that the block is YAML-only with no dotted-key or classic-mode form. - pipeline-section.md: document the per-input enabled override and that the limits are service-level only. - monitoring.md: add fluentbit_input_logs_tag_records_total and fluentbit_input_logs_tag_records_untracked_total, including the max_series, tag_length_limit, and error reason labels. Signed-off-by: Eric D. Schabell <eric@schabell.org> * docs: administration: yaml: document tag_records limit validation rules The max_series and max_tag_length rows documented the 0 sentinel but not the accepted types or what happens on a bad value. - Note that both limits accept an integer or an integer-only string, that strings are environment-variable expanded, and that the value must fit in a signed 32-bit integer. - Document that unparsable or out-of-range values fail at startup. - Correct the sentinel: 0 or less removes the limit. Neither limit enforces a minimum, so negative values are accepted rather than rejected. Signed-off-by: Eric D. Schabell <eric@schabell.org> --------- Signed-off-by: Eric D. Schabell <eric@schabell.org> Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Document the service-level telemetry.metrics.logs.tag_records block, its per-input enabled override, and the two metrics it exposes:
Summary by CodeRabbit