Skip to content

docs: administration: document logs tag records telemetry metrics - #2655

Merged
eschabell merged 2 commits into
fluent:masterfrom
eschabell:erics_tag_records_telemetry_metrics_updates
Aug 5, 2026
Merged

docs: administration: document logs tag records telemetry metrics#2655
eschabell merged 2 commits into
fluent:masterfrom
eschabell:erics_tag_records_telemetry_metrics_updates

Conversation

@eschabell

@eschabell eschabell commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Document the service-level telemetry.metrics.logs.tag_records block, its per-input enabled override, and the two metrics it exposes:

  • service-section.md: add a Telemetry configuration section covering enabled, max_series, and max_tag_length, and note that the block is YAML-only with no dotted-key or classic-mode form.
  • pipeline-section.md: document the per-input enabled override and that the limits are service-level only.
  • monitoring.md: add fluentbit_input_logs_tag_records_total and fluentbit_input_logs_tag_records_untracked_total, including the max_series, tag_length_limit, and error reason labels.

Summary by CodeRabbit

  • Documentation
    • Added guidance for configuring per-input log record counting by tag.
    • Documented service-wide telemetry settings, cardinality limits, tag-length restrictions, and startup validation.
    • Added YAML configuration examples, including disabling tracking for high-cardinality inputs.
    • Documented metrics for ingested records by tag and records that could not be tracked, including cardinality and tag-length failure reasons.

@eschabell eschabell self-assigned this Aug 4, 2026
@eschabell
eschabell requested a review from a team as a code owner August 4, 2026 07:27
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0.9 labels Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d517daca-206c-4b3f-8a1f-9da633580cf4

📥 Commits

Reviewing files that changed from the base of the PR and between f60d18c and 69be352.

📒 Files selected for processing (3)
  • administration/configuring-fluent-bit/yaml/pipeline-section.md
  • administration/configuring-fluent-bit/yaml/service-section.md
  • administration/monitoring.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • administration/configuring-fluent-bit/yaml/service-section.md
  • administration/monitoring.md
  • administration/configuring-fluent-bit/yaml/pipeline-section.md

📝 Walkthrough

Walkthrough

The documentation describes service and input configuration for per-tag log record metrics. It also documents tracked and untracked input metrics, their labels, cardinality limits, validation rules, and configuration requirements.

Changes

Telemetry metrics documentation

Layer / File(s) Summary
Telemetry configuration and input overrides
administration/configuring-fluent-bit/yaml/service-section.md, administration/configuring-fluent-bit/yaml/pipeline-section.md
Documents service telemetry settings, input overrides, validation rules, limits, inheritance, and YAML examples.
Per-tag monitoring metrics
administration/monitoring.md
Documents tracked and untracked per-tag input log record metrics, labels, failure reasons, and configuration requirements.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: 5.0

Suggested reviewers: patrick-stephens, cosmo0920

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the documentation change for logs tag records telemetry metrics.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@administration/configuring-fluent-bit/yaml/service-section.md`:
- Around line 51-59: Update the `max_series` and `max_tag_length` entries in the
`telemetry.metrics.logs.tag_records` configuration table to document their
accepted type, minimum value, and startup behavior for invalid values, including
the existing `0` sentinel semantics. State the exact validation rules for both
numeric limits and preserve the current defaults and descriptions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a8c5a4f3-4996-449b-a626-8c8c48f39d36

📥 Commits

Reviewing files that changed from the base of the PR and between 4a9a22b and d2089e2.

📒 Files selected for processing (3)
  • administration/configuring-fluent-bit/yaml/pipeline-section.md
  • administration/configuring-fluent-bit/yaml/service-section.md
  • administration/monitoring.md

Comment thread administration/configuring-fluent-bit/yaml/service-section.md Outdated
@eschabell

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eschabell

Copy link
Copy Markdown
Collaborator Author

@patrick-stephens ready for review!

@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Aug 5, 2026
Document the service-level telemetry.metrics.logs.tag_records block, its
per-input enabled override, and the two metrics it exposes:

- service-section.md: add a Telemetry configuration section covering
  enabled, max_series, and max_tag_length, and note that the block is
  YAML-only with no dotted-key or classic-mode form.
- pipeline-section.md: document the per-input enabled override and that
  the limits are service-level only.
- monitoring.md: add fluentbit_input_logs_tag_records_total and
  fluentbit_input_logs_tag_records_untracked_total, including the
  max_series, tag_length_limit, and error reason labels.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
The max_series and max_tag_length rows documented the 0 sentinel but not
the accepted types or what happens on a bad value.

- Note that both limits accept an integer or an integer-only string, that
  strings are environment-variable expanded, and that the value must fit
  in a signed 32-bit integer.
- Document that unparsable or out-of-range values fail at startup.
- Correct the sentinel: 0 or less removes the limit. Neither limit
  enforces a minimum, so negative values are accepted rather than
  rejected.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell force-pushed the erics_tag_records_telemetry_metrics_updates branch from 2f909b3 to 69be352 Compare August 5, 2026 12:30
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@eschabell
eschabell merged commit 8d994ab into fluent:master Aug 5, 2026
8 checks passed
@eschabell
eschabell deleted the erics_tag_records_telemetry_metrics_updates branch August 5, 2026 12:32
@eschabell eschabell added 5.1 and removed 5.0.9 labels Aug 6, 2026
patrick-stephens pushed a commit that referenced this pull request Aug 7, 2026
)

* docs: administration: document logs tag records telemetry metrics

Document the service-level telemetry.metrics.logs.tag_records block, its
per-input enabled override, and the two metrics it exposes:

- service-section.md: add a Telemetry configuration section covering
  enabled, max_series, and max_tag_length, and note that the block is
  YAML-only with no dotted-key or classic-mode form.
- pipeline-section.md: document the per-input enabled override and that
  the limits are service-level only.
- monitoring.md: add fluentbit_input_logs_tag_records_total and
  fluentbit_input_logs_tag_records_untracked_total, including the
  max_series, tag_length_limit, and error reason labels.

Signed-off-by: Eric D. Schabell <eric@schabell.org>

* docs: administration: yaml: document tag_records limit validation rules

The max_series and max_tag_length rows documented the 0 sentinel but not
the accepted types or what happens on a bad value.

- Note that both limits accept an integer or an integer-only string, that
  strings are environment-variable expanded, and that the value must fit
  in a signed 32-bit integer.
- Document that unparsable or out-of-range values fail at startup.
- Correct the sentinel: 0 or less removes the limit. Neither limit
  enforces a minimum, so negative values are accepted rather than
  rejected.

Signed-off-by: Eric D. Schabell <eric@schabell.org>

---------

Signed-off-by: Eric D. Schabell <eric@schabell.org>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants