-
Notifications
You must be signed in to change notification settings - Fork 544
service: add thread.flush_on_shutdown option #2332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdded documentation for a new Service configuration key Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for the new thread.flush_on_shutdown configuration option in the SERVICE section of Fluent Bit. This option controls whether the engine waits for threaded input ring buffers to flush during graceful shutdown, preventing data loss from threaded inputs.
Changes:
- Added documentation for the
thread.flush_on_shutdownoption with description, accepted values, and default value - Documentation updated in both YAML and classic mode configuration files for consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| administration/configuring-fluent-bit/yaml/service-section.md | Added thread.flush_on_shutdown option to the service section table with description, accepted values, and default value |
| administration/configuring-fluent-bit/classic-mode/configuration-file.md | Added thread.flush_on_shutdown option to the Service section table with description, allowed values, and default value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
administration/configuring-fluent-bit/classic-mode/configuration-file.md
Outdated
Show resolved
Hide resolved
This commit adds documentation for the new `thread.flush_on_shutdown` configuration option in the SERVICE section. When enabled, the engine waits for threaded input ring buffers to flush during graceful shutdown, preventing data loss from threaded inputs. refs: fluent/fluent-bit#11337 Signed-off-by: jinyong.choi <inimax801@gmail.com>
234442d to
b6c6850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The related code PR (fluent/fluent-bit#11337) is included in the 5.0.0 milestone. |
|
Yeah we cannot merge until the change is in a release otherwise it'll confuse people |
eschabell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@jinyongchoi just waiting on the code PR to merge, thanks for this PR! |
Summary
This commit adds documentation for the new
thread.flush_on_shutdownconfiguration option in the SERVICE section.When enabled, the engine waits for threaded input ring buffers to flush during graceful shutdown, preventing data loss from threaded inputs.
Changed files
administration/configuring-fluent-bit/yaml/service-section.mdadministration/configuring-fluent-bit/classic-mode/configuration-file.mdRelated PR
fluent/fluent-bit#11337
Summary by CodeRabbit
thread.flush_on_shutdownto the Service section documentation. The entry documents accepted values (on/off) and default (off). Check the updated service configuration docs for details.✏️ Tip: You can customize this high-level summary in your review settings.