out_opentelemetry: adjust add_label description#1060
Merged
patrick-stephens merged 5 commits intofluent:masterfrom Oct 21, 2025
Merged
out_opentelemetry: adjust add_label description#1060patrick-stephens merged 5 commits intofluent:masterfrom
add_label description#1060patrick-stephens merged 5 commits intofluent:masterfrom
Conversation
3 tasks
Frefreak
changed the title
add_label descriptionadd_label description
patrick-stephens
approved these changes
May 16, 2023
Contributor
|
Ah, DCO checks are failing |
Contributor
Author
|
yep, I forget to sign. Will force push in a moment. Sorry |
Frefreak
force-pushed
the
opentelemtry_add_label_doc
branch
2 times, most recently
from
3662364 to
134c016
Compare
Contributor
Author
|
updated |
Frefreak
force-pushed
the
opentelemtry_add_label_doc
branch
from
134c016 to
6bdcd26
Compare
Signed-off-by: Frefreak <frefreak.zxy@gmail.com>
Frefreak
force-pushed
the
opentelemtry_add_label_doc
branch
from
6bdcd26 to
581cbda
Compare
eschabell
added
waiting-for-user
Collaborator
|
@Frefreak if you can resolve the conflicts here I can merge this for you? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
Contributor
|
Stylistic changes caused the conflict, I corrected it so this can keep moving. |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
esmerel
reviewed
Oct 21, 2025
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
Contributor
|
Corrected the conflict incorrectly, then hopefully I fixed it with the updated description and kept the style correct. |
esmerel
reviewed
Oct 21, 2025
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
esmerel
approved these changes
Oct 21, 2025
Contributor
Author
|
Sorry for missing the notification, thank you for the fix! |
TomlinfreeGit
pushed a commit
to TomlinfreeGit/fluent-bit-docs
that referenced
this pull request
Oct 28, 2025
* out_opentelemetry: adjust `add_label` description Signed-off-by: Frefreak <frefreak.zxy@gmail.com> * Update opentelemetry.md Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> * Update pipeline/outputs/opentelemetry.md Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> --------- Signed-off-by: Frefreak <frefreak.zxy@gmail.com> Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Tom <yao.lin@siemens.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_labelcan add attributes to logs data (Resource attributes instead of LogRecord's attributes) after this PR: fluent/fluent-bit#7029