Handle fallocate errors on legacy linuxes #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older linuxes as e.g. SLES 11 SP4 does not return EOPNOTSUPP for not supported filesystem. Instead it returns the generic -1 failure and sets the errno with description Operation not supported. This fix does instead check if the operation failes with a non zero return value and in such cases revert to posix_fallocate. Other errors as e.g. ENOSPC will hence rely to be returned by the call to posix_fallocate. Signed-off-by: sirwio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older linuxes as e.g. SLES 11 SP4 does not return EOPNOTSUPP for not supported
filesystem. Instead it returns the generic -1 failure and sets the errno with
description Operation not supported. This fix does instead check if the
operation failes with a non zero return value and in such cases revert to
posix_fallocate. Other errors as e.g. ENOSPC will hence rely to be returned by
the call to posix_fallocate.
Signed-off-by: sirwio [email protected]