-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand SID with actual user name and domain #46
Conversation
This is needed to compete for the competitor of elastic beats. ref: https://www.elastic.co/guide/en/beats/filebeat/current/processor-translate-sid.html Signed-off-by: Hiroshi Hatake <[email protected]>
In addition, we already implemented this feature on Fluent Bit. I ported and modified for winevt_c adoptions. |
28925e9
to
3354fe3
Compare
…ng SID Signed-off-by: Hiroshi Hatake <[email protected]>
7177dc9
to
004c57e
Compare
AppVeyor failures on Ruby 2.6 and 2.7 is reported here: appveyor/ci#3928 |
dd2f57f
to
36c86f9
Compare
Suggested by @OwenMcDonnell. Signed-off-by: Hiroshi Hatake <[email protected]>
36c86f9
to
360e2b7
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
With applying this patch, the example xml false case could retrieve SID translated User record:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for this enhancement!
Signed-off-by: Hiroshi Hatake <[email protected]>
This Ruby C extension does not need to pass valgrind check. We can remove them without this check because free(3) is safe for passing NULL. Signed-off-by: Hiroshi Hatake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is nothing else to be concerned at this time.
If we have any other concerns later, we'll address them in other PR.
Thanks for your effort!
@cosmo0920 |
Yes, go ahead. |
This is needed to compete for the competitor of elastic beats.
ref: https://www.elastic.co/guide/en/beats/filebeat/current/processor-translate-sid.html