utils: Remove needless NULL check

This Ruby C extension does not need to pass valgrind check. We can remove them without this check because free(3) is safe for passing NULL. Signed-off-by: Hiroshi Hatake <[email protected]>
fluent-plugins-nursery · Jul 31, 2024 · 89c429e · 89c429e
1 parent 616a664
commit 89c429e
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/ext/winevt/winevt_utils.cpp b/ext/winevt/winevt_utils.cpp
@@ -670,12 +670,8 @@ static int ExpandSIDWString(PSID sid, CHAR **out_expanded)
 
   *out_expanded = strdup(formatted);
 
-  if (domain != NULL) {
-    free(domain);
-  }
-  if (account != NULL) {
-    free(account);
-  }
+  free(domain);
+  free(account);
   RB_ALLOCV_END(vformatted);
 
 
@@ -689,12 +685,8 @@ static int ExpandSIDWString(PSID sid, CHAR **out_expanded)
   err = GetLastError();
 
   RB_ALLOCV_END(vformatted);
-  if (domain != NULL) {
-    free(domain);
-  }
-  if (account != NULL) {
-    free(account);
-  }
+  free(domain);
+  free(account);
   raise_system_error(rb_eRuntimeError, err);
 }