Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add libiconv for rust cookbook #20

Merged
merged 1 commit into from
Sep 12, 2024
Merged

chore: add libiconv for rust cookbook #20

merged 1 commit into from
Sep 12, 2024

Conversation

zmitchell
Copy link
Contributor

This is necessary on macOS and was just left out by mistake

@floxbot floxbot added the documentation Improvements or additions to documentation label Sep 12, 2024
Copy link

@@ -27,6 +27,8 @@ rustfmt.pkg-path = "rustfmt"
rustfmt.pkg-group = "rust-toolchain"
rust-lib-src.pkg-path = "rustPlatform.rustLibSrc"
rust-lib-src.pkg-group = "rust-toolchain"
libiconv.pkg-path = "libiconv"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually import darwin.libiconv but i guess that will be the same

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically also not always necessary.
another frequently required packages is darwin.apple_sdk.frameworks.SystemConfiguration

@ysndr ysndr merged commit 1ac1b4f into preview Sep 12, 2024
4 checks passed
@ysndr ysndr deleted the zmitchell-patch-1 branch September 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants