Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #994

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

  • build workflows

Changed

Removed

  • deprecated classes/methods

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Feb 18, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev           |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.283mb -0.01%  | 819.682ms +1.05% | ±1.98% +1475.27% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.006mb -0.08%   | 342.295ms +0.32% | ±0.41% +55.50%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.157mb -0.08%   | 1.050s +0.51%    | ±0.10% -88.14%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.821mb -0.00% | 895.131ms +0.88% | ±0.56% +582.97%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.914mb -0.08%   | 35.451ms +0.10%  | ±0.99% +180.31%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.920mb -0.08%   | 435.707ms +0.72% | ±0.29% -62.68%   |
+-----------------------+-------------------+------+-----+------------------+------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.620mb -0.00% | 64.098ms -2.59% | ±0.92% +23.34% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.663mb -0.00%  | 464.964ms +3.59% | ±0.40% +100.62% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.145mb -0.01%  | 72.311ms +3.01%  | ±0.74% -36.23%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.571mb -0.00% | 52.994ms +1.20%  | ±1.07% +105.39% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 224.388mb -0.00% | 1.422s +0.66%    | ±0.33% -72.08%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.961mb -0.02%  | 39.595ms +3.04%  | ±0.46% +112.11% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.718mb -0.00% | 503.776ms +3.06% | ±1.67% +24.44%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.196mb -0.01%  | 247.907ms +1.05% | ±0.14% -71.19%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.131mb -0.02%  | 52.728ms +1.91%  | ±2.01% +463.36% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.962mb -0.01%  | 433.775ms +0.94% | ±0.53% -38.48%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.501mb -0.03%  | 86.735ms +1.59%  | ±0.46% -54.03%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.686mb -0.00%  | 3.395ms +2.70%   | ±0.32% -75.86%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.413mb -0.00%  | 185.239ms -0.89% | ±0.36% -56.66%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.939mb -0.00%  | 18.874ms +1.42%  | ±1.03% -3.31%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.926mb -0.00%  | 1.874ms +19.11%  | ±0.22% -91.68%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.926mb -0.00%  | 1.819ms +16.17%  | ±2.07% +101.28% |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.038mb -0.00%  | 2.654ms +6.91%   | ±0.90% -55.67%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.567mb -0.00%  | 17.436ms +20.10% | ±2.37% +370.94% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.567mb -0.00%  | 17.786ms +21.08% | ±0.50% -84.78%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.472mb -0.01%  | 1.894μs +5.57%   | ±2.53% -5.36%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.472mb -0.01%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.026mb -0.00%  | 13.033ms +2.12%  | ±1.11% -29.14%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.387mb -0.00% | 65.491ms +0.01%  | ±0.58% -25.53%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.087mb -0.00%  | 1.354ms +17.01%  | ±3.21% +109.73% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.434mb -0.00%  | 61.176ms +7.42%  | ±0.84% -23.88%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.189mb -0.00%  | 3.929ms +3.79%   | ±1.74% +357.99% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.550mb -0.01%  | 41.496ms +2.92%  | ±0.91% -26.30%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.550mb -0.01%  | 41.886ms +3.20%  | ±0.97% -58.60%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.550mb -0.01%  | 43.475ms +5.80%  | ±2.71% +346.69% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.913mb -0.00%  | 7.313ms +0.14%   | ±1.27% -1.78%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.472mb -0.01%  | 29.319ms +1.29%  | ±1.72% +73.15%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.472mb -0.01%  | 13.312μs -6.44%  | ±0.71% -79.41%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.472mb -0.01%  | 16.310μs +2.62%  | ±3.24% +992.19% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.480mb -0.00%  | 188.923ms -5.98% | ±0.31% -84.65%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@github-actions github-actions bot added the docs label Feb 18, 2024
@norberttech norberttech merged commit 3d40494 into flow-php:1.x Feb 18, 2024
18 checks passed
@norberttech norberttech added this to the 0.7.0 milestone Mar 11, 2024
@norberttech norberttech deleted the feature/remove-deprecated-code branch May 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant