Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved filesystem related exceptions #1041

Merged

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

  • Invalid inputs now throws InvalidArgumentException
  • Missing file/directory now throws FileNotFoundException

Changed

Removed

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Apr 6, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.297mb +0.00%  | 841.653ms -1.98% | ±1.09% +151.75% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 5.017mb +0.01%   | 345.204ms -0.01% | ±0.57% -73.90%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.172mb +0.01%   | 1.086s +0.15%    | ±1.29% -10.83%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.838mb +0.00% | 922.125ms -0.12% | ±0.48% -44.54%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.927mb +0.01%   | 35.679ms -0.95%  | ±0.71% +27.85%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.933mb +0.01%   | 438.330ms -0.43% | ±0.18% -86.15%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.238mb +0.00% | 60.383ms -1.83% | ±1.15% +31.58% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 96.683mb +0.00%  | 478.136ms +3.24% | ±0.17% -62.40% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 55.162mb +0.00%  | 70.679ms -2.53%  | ±0.66% -3.42%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 107.592mb +0.00% | 51.424ms -3.57%  | ±0.30% -61.36% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 227.006mb +0.00% | 1.421s -1.50%    | ±0.15% -54.05% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.975mb +0.00%  | 40.469ms -1.12%  | ±0.62% +2.18%  |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.059mb +0.00%  | 3.374ms -14.93%  | ±1.94% +66.52%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.657mb +0.00% | 190.666ms -0.47% | ±1.04% +194.19%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.377mb +0.00%  | 18.852ms -4.10%  | ±1.25% +50.30%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.299mb +0.00%  | 1.691ms -15.16%  | ±3.02% +54.69%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.299mb +0.00%  | 1.646ms -19.06%  | ±1.09% -66.89%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.411mb +0.00%  | 2.662ms -15.93%  | ±0.49% -67.94%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.940mb +0.00%  | 16.520ms -4.50%  | ±1.17% +2.97%    |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.940mb +0.00%  | 16.978ms -3.18%  | ±1.01% +123.93%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.844mb +0.00%  | 1.706μs -14.70%  | ±2.72% +0.00%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.844mb +0.00%  | 0.400μs -20.00%  | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.194mb +0.00%  | 12.782ms -12.24% | ±1.26% -51.57%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.565mb +0.00% | 62.884ms -2.09%  | ±1.06% +117.24%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.460mb +0.00%  | 1.214ms -29.73%  | ±1.07% -40.49%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.807mb +0.00%  | 63.508ms -7.76%  | ±3.36% +5281.34% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.561mb +0.00%  | 3.852ms -10.58%  | ±0.41% -55.88%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.988mb +0.00%  | 40.675ms -5.11%  | ±1.41% -46.94%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.989mb +0.00%  | 40.082ms -5.92%  | ±0.89% +92.77%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.988mb +0.00%  | 40.311ms -6.41%  | ±0.53% +51.14%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.285mb +0.00%  | 7.483ms -4.09%   | ±1.41% -11.41%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.844mb +0.00%  | 28.522ms -8.80%  | ±1.12% -24.51%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.844mb +0.00%  | 13.179μs -7.06%  | ±0.94% -20.89%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.844mb +0.00%  | 15.918μs -3.99%  | ±0.88% -13.33%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.658mb +0.00% | 192.580ms -3.30% | ±1.58% +223.98%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.969mb +0.00%  | 437.423ms -0.61% | ±0.12% -74.18%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.508mb +0.00%  | 86.258ms -2.56%  | ±1.08% +49.92%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.737mb +0.00% | 523.444ms +0.87% | ±1.33% +79.89%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.215mb +0.00%  | 259.586ms -0.94% | ±1.00% +30.41%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.149mb +0.00%  | 54.797ms -4.77%  | ±0.83% -49.89%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit c07def4 into flow-php:1.x Apr 6, 2024
17 checks passed
@norberttech norberttech deleted the feature/missing-file-exception branch May 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant