Fix compute bar width #1663
Fix compute bar width #1663
Conversation
| xValues = xValues.filter( onlyUnique ); | ||
|
|
||
| for (var j = 1; j < xValues.length; j++) { | ||
| distance = Math.abs(xValues[j] - xValues[j - 1]); |
There was a problem hiding this comment.
So, in our discussion I was under the impression that xValues was sorted AND filtered for unique values, but this only seems to be filtered for unique values. Sorting still seems important for the following scenario:
data input:
{ {3, 5, 0}, {8, 2, 0}, {1, 2, 0} } (So, x-values of 3, 8, 1).
The algorithm as written will come up with a distance of 5. Whereas with sorting it will come up with a distance of 2.
Edit: I just saw that you removed a change that was, indeed, doing the sort. Why did you decide it wasn't needed?
There was a problem hiding this comment.
In the end I decided that eliminating duplicates was the way to go. That is what the category axis itself does. Sorting yielded incorrect results.
There was a problem hiding this comment.
After reviewing the behavior described above, Andrew and I are in agreement that the preferred behavior requires the x-values to be sorted. Had to update a test as a result of that.
Sort the x-values before computing bar width.
Fix test.
This fixes an issue where if there are duplicate categories in a category axis the bar width ends up being zero.