model/profile: add location information#1
Closed
florianl wants to merge 2 commits intoprofiles-symb-levelfrom
Closed
model/profile: add location information#1florianl wants to merge 2 commits intoprofiles-symb-levelfrom
florianl wants to merge 2 commits intoprofiles-symb-levelfrom
Conversation
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
added a commit
to florianl/opentelemetry-proto
that referenced
this pull request
Jul 30, 2025
Similar to the boolean attributes `Mapping.has_*` (open-telemetry#595 and open-telemetry/semantic-conventions#2522) also drop `Location.is_folded`. The complementary PR for the OTel SemConv, that builds on top of open-telemetry/semantic-conventions#2522 is florianl/semantic-conventions#1
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Owner
Author
|
Cherry-picked this PR into open-telemetry#2522. |
tigrannajaryan
added a commit
to open-telemetry/opentelemetry-proto
that referenced
this pull request
Aug 11, 2025
Similar to the boolean attributes `Mapping.has_*` (#595 and open-telemetry/semantic-conventions#2522) also drop `Location.is_folded`. The complementary PR for the OTel SemConv, that builds on top of open-telemetry/semantic-conventions#2522 is florianl/semantic-conventions#1 Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add Profiling specific attributes for pprof location.
This change is based on top of open-telemetry#2522 to not conflict with
registry.profile.pprof.FYI: @open-telemetry/profiling-approvers
Merge requirement checklist
[chore]