profiles: improve sample_type comment#1
Merged
florianl merged 1 commit intoflorianl:issue-633from May 27, 2025
Merged
Conversation
I think using nanoseconds is the better default unit for CPU profiles because the weight of a count can be different depending on the sample rate. Using the same unit for off_cpu and cpu is more consistent. The comment above was a little confusing, since it referred only to a cpu profile, but was then followed by an off_cpu profile sample as well.
felixge
changed the title
florianl
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For open-telemetry#649