fix errant framebuffer bind #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the framebuffer was getting bound even when msaa hadn't changed it
|
Oops yeah looks like a bug. This was a "fix" for a rendering corruption problem on Chrome on Windows (https://bugs.chromium.org/p/chromium/issues/detail?id=1453425) I'll need to check whether the "fix" was actually only working because it contained this bug. I'll try to look into this today (only downside is I have no Windows machine for testing around today). Thanks for the PR! |
|
Ok tested (only on my Mac though) and merged. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the framebuffer was getting bound even when msaa hadn't changed it