Refactor 0.3 #59
Merged
Refactor 0.3 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it; refactor express away from live view server
…_map.json, add README, and generally make project easy to grok
… folks to grok liveviewjs with express
…rent lifecycle has sent a response to process
This was referenced May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a re-architecture, refactoring of LiveViewJS into multiple different packages primarily to support both NodeJS and Deno runtimes.
Package structure is:
<root>- "Core" LiveViewJS package that defines the main types, implement the LiveViewProtocol, and management of LiveViews for HTTP and Websockets. This is written in TS that works both on NodeJS and Deno.packages/examples- numerous LiveViewJS examples show both simple and complex LiveViews which are usable in both NodeJS and Denopackages/deno- Code that enables developers to use LiveViewJS in their Deno + Oak applications along with a working example Deno + Oak server which loads the LiveView examples frompackages/example.packages/express- Code that enables developers to use LiveViewJS in their NodeJS + ExpressJS applications along with a working example NodeJS + Express server which loads the LiveView examples frompackages/example.In addition, we cleaned up the type system, refactored a bunch of types, fixed bugs, written tests, and generally learned a lot! Also fixed #25, #30 , #36