Merge pull request #39 from floodfx/express_route_next

do not return 404 if liveview route not found, instead call next() to…
floodfx · Feb 18, 2022 · 9e07d22 · 9e07d22
2 parents 1d8a20d + 609f5ff
commit 9e07d22
Show file tree

Hide file tree

Showing 38 changed files with 123 additions and 77 deletions.
diff --git a/README.md b/README.md
@@ -168,6 +168,8 @@ lvServer.start();
 
 ### Additional Feature Documentation
  * [Updating HTML Document `<title />`](docs/updating-html-title.md)
+ * [LiveViewJS Changesets](docs/changesets.md).
+ * [Routing Details](docs/routing.md).
 
 #### Other features to be implemented:
 * [LiveView Helpers](https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.Helpers.html) - Vote for [Issue 17](https://github.com/floodfx/liveviewjs/issues/17)

diff --git a/coverage/clover.xml b/coverage/clover.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<coverage generated="1644989803167" clover="3.2.0">
-  <project timestamp="1644989803167" name="All files">
+<coverage generated="1645213637664" clover="3.2.0">
+  <project timestamp="1645213637664" name="All files">
     <metrics statements="469" coveredstatements="469" conditionals="272" coveredconditionals="258" methods="90" coveredmethods="89" elements="831" coveredelements="816" complexity="0" loc="469" ncloc="469" packages="8" files="21" classes="21"/>
     <package name="examples.autocomplete">
       <metrics statements="5" coveredstatements="5" conditionals="1" coveredconditionals="1" methods="2" coveredmethods="2"/>
@@ -129,15 +129,15 @@
         <line num="151" count="2" type="stmt"/>
         <line num="161" count="2" type="stmt"/>
         <line num="162" count="2" type="cond" truecount="1" falsecount="0"/>
+        <line num="165" count="1" type="stmt"/>
         <line num="166" count="1" type="stmt"/>
-        <line num="167" count="1" type="stmt"/>
-        <line num="171" count="1" type="cond" truecount="1" falsecount="0"/>
-        <line num="172" count="1" type="stmt"/>
-        <line num="175" count="1" type="stmt"/>
+        <line num="170" count="1" type="cond" truecount="1" falsecount="0"/>
+        <line num="171" count="1" type="stmt"/>
+        <line num="174" count="1" type="stmt"/>
+        <line num="179" count="1" type="stmt"/>
         <line num="180" count="1" type="stmt"/>
-        <line num="181" count="1" type="stmt"/>
-        <line num="184" count="1" type="stmt"/>
-        <line num="196" count="8" type="stmt"/>
+        <line num="183" count="1" type="stmt"/>
+        <line num="195" count="8" type="stmt"/>
       </file>
     </package>
     <package name="server.component">

diff --git a/coverage/coverage-final.json b/coverage/coverage-final.json
diff --git a/coverage/lcov-report/examples/autocomplete/data.ts.html b/coverage/lcov-report/examples/autocomplete/data.ts.html
@@ -3106,7 +3106,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">examples/aut
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/examples/autocomplete/index.html b/coverage/lcov-report/examples/autocomplete/index.html
@@ -101,7 +101,7 @@ <h1><a href="../../index.html">All files</a> examples/autocomplete</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/examples/live-search/data.ts.html b/coverage/lcov-report/examples/live-search/data.ts.html
@@ -331,7 +331,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">examples/liv
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/examples/live-search/index.html b/coverage/lcov-report/examples/live-search/index.html
@@ -101,7 +101,7 @@ <h1><a href="../../index.html">All files</a> examples/live-search</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/examples/volunteers/data.ts.html b/coverage/lcov-report/examples/volunteers/data.ts.html
@@ -220,7 +220,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">examples/vol
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/examples/volunteers/index.html b/coverage/lcov-report/examples/volunteers/index.html
@@ -101,7 +101,7 @@ <h1><a href="../../index.html">All files</a> examples/volunteers</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/index.html b/coverage/lcov-report/index.html
@@ -206,7 +206,7 @@ <h1>All files</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/component/base_component.ts.html b/coverage/lcov-report/server/component/base_component.ts.html
@@ -169,7 +169,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/compo
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/component/changeset.ts.html b/coverage/lcov-report/server/component/changeset.ts.html
@@ -148,7 +148,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/compo
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/component/index.html b/coverage/lcov-report/server/component/index.html
@@ -131,7 +131,7 @@ <h1><a href="../../index.html">All files</a> server/component</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/component/index.ts.html b/coverage/lcov-report/server/component/index.ts.html
@@ -76,7 +76,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/compo
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/index.html b/coverage/lcov-report/server/index.html
@@ -116,7 +116,7 @@ <h1><a href="../index.html">All files</a> server</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/index.ts.html b/coverage/lcov-report/server/index.ts.html
@@ -85,7 +85,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> inde
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/live_view_server.ts.html b/coverage/lcov-report/server/live_view_server.ts.html
@@ -259,8 +259,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> live
 <a name='L194'></a><a href='#L194'>194</a>
 <a name='L195'></a><a href='#L195'>195</a>
 <a name='L196'></a><a href='#L196'>196</a>
-<a name='L197'></a><a href='#L197'>197</a>
-<a name='L198'></a><a href='#L198'>198</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
+<a name='L197'></a><a href='#L197'>197</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">4x</span>
 <span class="cline-any cline-yes">4x</span>
 <span class="cline-any cline-yes">4x</span>
@@ -424,7 +423,6 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> live
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -600,7 +598,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> live
     // register live_title_tag helper
     app.locals.live_title_tag = live_title_tag;
 &nbsp;
-    app.get('/:liveview', async (req, res) =&gt; {
+    app.get('/:liveview', async (req, res, next) =&gt; {
       const liveview = req.params.liveview;
 &nbsp;
       const emptyVoid = <span class="fstat-no" title="function not covered" >() =</span>&gt; { };
@@ -619,10 +617,9 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> live
       // look up component for route
       const component = this._router[`/${liveview}`];
       if (!component) {
-        // TODO which is better 404 or just call next()?
-        // next();
-        // return;
-        res.status(404).send("Not found");
+        // no component found for route so call next() to
+        // let a possible downstream route handle the request
+        next();
         return;
       }
 &nbsp;
@@ -661,7 +658,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> live
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/socket/component_manager.ts.html b/coverage/lcov-report/server/socket/component_manager.ts.html
@@ -934,7 +934,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/socke
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/socket/index.html b/coverage/lcov-report/server/socket/index.html
@@ -146,7 +146,7 @@ <h1><a href="../../index.html">All files</a> server/socket</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/socket/message_router.ts.html b/coverage/lcov-report/server/socket/message_router.ts.html
@@ -415,7 +415,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/socke
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/socket/types.ts.html b/coverage/lcov-report/server/socket/types.ts.html
@@ -373,7 +373,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/socke
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/socket/util.ts.html b/coverage/lcov-report/server/socket/util.ts.html
@@ -139,7 +139,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/socke
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/diff.ts.html b/coverage/lcov-report/server/templates/diff.ts.html
@@ -346,7 +346,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/templ
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/helpers/form_for.ts.html b/coverage/lcov-report/server/templates/helpers/form_for.ts.html
@@ -118,7 +118,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/helpers/index.html b/coverage/lcov-report/server/templates/helpers/index.html
@@ -191,7 +191,7 @@ <h1><a href="../../../index.html">All files</a> server/templates/helpers</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/helpers/index.ts.html b/coverage/lcov-report/server/templates/helpers/index.ts.html
@@ -85,7 +85,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/helpers/inputs.ts.html b/coverage/lcov-report/server/templates/helpers/inputs.ts.html
@@ -187,7 +187,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/helpers/live_patch.ts.html b/coverage/lcov-report/server/templates/helpers/live_patch.ts.html
@@ -139,7 +139,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/helpers/live_title_tag.ts.html b/coverage/lcov-report/server/templates/helpers/live_title_tag.ts.html
@@ -106,7 +106,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/helpers/options_for_select.ts.html b/coverage/lcov-report/server/templates/helpers/options_for_select.ts.html
@@ -256,7 +256,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>

diff --git a/coverage/lcov-report/server/templates/helpers/submit.ts.html b/coverage/lcov-report/server/templates/helpers/submit.ts.html
@@ -97,7 +97,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Feb 15 2022 22:36:43 GMT-0700 (Mountain Standard Time)
+                at Fri Feb 18 2022 12:47:17 GMT-0700 (Mountain Standard Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>