Skip to content

Commit

Permalink
do not export html as default from template module; fix imports every…
Browse files Browse the repository at this point in the history
…where; actually use root template in liveview server
  • Loading branch information
floodfx committed Feb 10, 2022
1 parent 3ab968f commit 869264c
Show file tree
Hide file tree
Showing 54 changed files with 90 additions and 87 deletions.
4 changes: 2 additions & 2 deletions coverage/clover.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<coverage generated="1644477692883" clover="3.2.0">
<project timestamp="1644477692883" name="All files">
<coverage generated="1644517936335" clover="3.2.0">
<project timestamp="1644517936335" name="All files">
<metrics statements="386" coveredstatements="386" conditionals="184" coveredconditionals="176" methods="86" coveredmethods="83" elements="656" coveredelements="645" complexity="0" loc="386" ncloc="386" packages="8" files="20" classes="20"/>
<package name="examples.autocomplete">
<metrics statements="5" coveredstatements="5" conditionals="1" coveredconditionals="1" methods="2" coveredmethods="2"/>
Expand Down
12 changes: 6 additions & 6 deletions coverage/coverage-final.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion coverage/lcov-report/examples/autocomplete/data.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -3106,7 +3106,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">examples/aut
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/examples/autocomplete/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ <h1><a href="../../index.html">All files</a> examples/autocomplete</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/examples/live-search/data.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">examples/liv
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/examples/live-search/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ <h1><a href="../../index.html">All files</a> examples/live-search</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/examples/volunteers/data.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">examples/vol
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/examples/volunteers/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ <h1><a href="../../index.html">All files</a> examples/volunteers</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ <h1>All files</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="prettify.js"></script>
<script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/compo
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/component/changeset.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/compo
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/component/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ <h1><a href="../../index.html">All files</a> server/component</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/component/index.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/compo
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ <h1><a href="../index.html">All files</a> server</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/index.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> inde
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../prettify.js"></script>
<script>
Expand Down
6 changes: 3 additions & 3 deletions coverage/lcov-report/server/live_view_server.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> live
&nbsp;
export class LiveViewServer {
private port: number = 4444;
private rootView: string = "index.html.ejs";
private rootView: string = "root.html.ejs";
private viewsPath: string[];
private signingSecret: string;
private sessionStore: session.Store = new MemoryStore();
Expand Down Expand Up @@ -588,7 +588,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> live
const view = component.render(ctx);
&nbsp;
// render the view with all the data
res.render("root.html.ejs", {
res.render(this.rootView, {
page_title: "Live View",
csrf_meta_tag: req.session.csrfToken,
liveViewId,
Expand All @@ -607,7 +607,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">server</a> live
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../prettify.js"></script>
<script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/socke
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/socket/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ <h1><a href="../../index.html">All files</a> server/socket</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/socket/message_router.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/socke
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/socket/types.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/socke
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/socket/util.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">server/socke
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<span class="cline-any cline-yes">4x</span>
<span class="cline-any cline-yes">4x</span>
<span class="cline-any cline-yes">4x</span>
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import html from ".."
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { html } from ".."
&nbsp;
interface FormForOptions {
phx_submit?: string
Expand All @@ -112,7 +112,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/server/templates/helpers/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ <h1><a href="../../../index.html">All files</a> server/templates/helpers</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../../prettify.js"></script>
<script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../../prettify.js"></script>
<script>
Expand Down
6 changes: 3 additions & 3 deletions coverage/lcov-report/server/templates/helpers/inputs.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">1x</span>
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { LiveViewChangeset } from "../../component/types";
import html, { safe } from "../index"
import { html, safe } from "../index"
&nbsp;
interface InputOptions {
placeholder?: string
Expand All @@ -154,7 +154,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
const type = options?.type ?? "text";
const id = `input_${key}`;
const value = changeset.data[key]<span class="branch-0 cbranch-no" title="branch not covered" > ?? "</span>";
return html`&lt;input type="${type}" id="${id}" name="${key}" value="${value}"${autocomplete}${placeholder}${phx_debounce}/&gt;`
return html`&lt;input type="${type}" id="${id}" name="${String(key)}" value="${value}"${autocomplete}${placeholder}${phx_debounce}/&gt;`
}
&nbsp;
interface TelephoneInputOptions extends Omit&lt;InputOptions, "type"&gt; { }
Expand All @@ -181,7 +181,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../../prettify.js"></script>
<script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-yes">6x</span>
<span class="cline-any cline-yes">3x</span>
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import html, { HtmlSafeString, safe } from "..";
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { html, HtmlSafeString, safe } from "..";
&nbsp;
interface LiveViewPatchHelperOptions {
to: {
Expand Down Expand Up @@ -139,7 +139,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../../prettify.js"></script>
<script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../../prettify.js"></script>
<script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span>
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import html, { HtmlSafeString, join } from "..";
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { html, HtmlSafeString, join } from "..";
&nbsp;
type Options =
string[] | Record&lt;string, string&gt;
Expand Down Expand Up @@ -256,7 +256,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../../prettify.js"></script>
<script>
Expand Down
4 changes: 2 additions & 2 deletions coverage/lcov-report/server/templates/helpers/submit.ts.html
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<span class="cline-any cline-yes">6x</span>
<span class="cline-any cline-yes">2x</span>
<span class="cline-any cline-yes">2x</span>
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import html, { safe } from ".."
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { html, safe } from ".."
&nbsp;
interface SubmitOptions {
phx_disable_with: string
Expand All @@ -97,7 +97,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">server/te
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at Thu Feb 10 2022 00:21:32 GMT-0700 (Mountain Standard Time)
at Thu Feb 10 2022 11:32:16 GMT-0700 (Mountain Standard Time)
</div>
<script src="../../../prettify.js"></script>
<script>
Expand Down
Loading

0 comments on commit 869264c

Please sign in to comment.