Fix bug where undefined subscriber was causing crash

- bump patch version

.changeset/cyan-years-warn.md

@@ -0,0 +1,5 @@
+---
+"liveviewjs": patch
+---
+
+Fix unsubscribe bug with undefined subscriber

packages/core/coverage/clover.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<coverage generated="1665099616580" clover="3.2.0">
-  <project timestamp="1665099616580" name="All files">
-    <metrics statements="1014" coveredstatements="1006" conditionals="343" coveredconditionals="319" methods="220" coveredmethods="202" elements="1577" coveredelements="1527" complexity="0" loc="1014" ncloc="1014" packages="10" files="39" classes="39"/>
+<coverage generated="1665206221223" clover="3.2.0">
+  <project timestamp="1665206221223" name="All files">
+    <metrics statements="1017" coveredstatements="1008" conditionals="344" coveredconditionals="320" methods="220" coveredmethods="202" elements="1581" coveredelements="1530" complexity="0" loc="1017" ncloc="1017" packages="10" files="39" classes="39"/>
     <package name="server">
       <metrics statements="10" coveredstatements="10" conditionals="0" coveredconditionals="0" methods="0" coveredmethods="0"/>
       <file name="index.ts" path="/Users/donnie/src/github.com/floodfx/liveviewjs/packages/core/src/server/index.ts">
@@ -221,14 +221,14 @@
       </file>
     </package>
     <package name="server.pubsub">
-      <metrics statements="15" coveredstatements="15" conditionals="0" coveredconditionals="0" methods="3" coveredmethods="3"/>
+      <metrics statements="18" coveredstatements="17" conditionals="1" coveredconditionals="1" methods="3" coveredmethods="3"/>
       <file name="index.ts" path="/Users/donnie/src/github.com/floodfx/liveviewjs/packages/core/src/server/pubsub/index.ts">
         <metrics statements="2" coveredstatements="2" conditionals="0" coveredconditionals="0" methods="0" coveredmethods="0"/>
         <line num="1" count="8" type="stmt"/>
         <line num="2" count="8" type="stmt"/>
       </file>
       <file name="singleProcessPubSub.ts" path="/Users/donnie/src/github.com/floodfx/liveviewjs/packages/core/src/server/pubsub/singleProcessPubSub.ts">
-        <metrics statements="13" coveredstatements="13" conditionals="0" coveredconditionals="0" methods="3" coveredmethods="3"/>
+        <metrics statements="16" coveredstatements="15" conditionals="1" coveredconditionals="1" methods="3" coveredmethods="3"/>
         <line num="1" count="8" type="stmt"/>
         <line num="2" count="8" type="stmt"/>
         <line num="11" count="8" type="stmt"/>
@@ -239,9 +239,12 @@
         <line num="20" count="150" type="stmt"/>
         <line num="21" count="150" type="stmt"/>
         <line num="25" count="11" type="stmt"/>
-        <line num="30" count="133" type="stmt"/>
+        <line num="29" count="133" type="stmt"/>
         <line num="31" count="133" type="stmt"/>
-        <line num="33" count="133" type="stmt"/>
+        <line num="33" count="133" type="cond" truecount="1" falsecount="0"/>
+        <line num="34" count="133" type="stmt"/>
+        <line num="37" count="133" type="stmt"/>
+        <line num="39" count="0" type="stmt"/>
       </file>
     </package>
     <package name="server.socket">

packages/core/dist/liveview.js

@@ -1572,11 +1572,18 @@ class SingleProcessPubSub {
         await eventEmitter.emit(topic, data);
     }
     async unsubscribe(topic, subscriberId) {
-        // get subscriber function from id
-        const subscriber = this.subscribers[subscriberId];
-        await eventEmitter.removeListener(topic, subscriber);
-        // remove subscriber from subscribers
-        delete this.subscribers[subscriberId];
+        try {
+            // get subscriber function from id
+            const subscriber = this.subscribers[subscriberId];
+            if (subscriber) {
+                await eventEmitter.removeListener(topic, subscriber);
+            }
+            // remove subscriber from subscribers
+            delete this.subscribers[subscriberId];
+        }
+        catch (err) {
+            console.warn("error unsubscribing from topic", topic, err);
+        }
     }
 }
 

packages/core/dist/liveview.mjs

@@ -1565,11 +1565,18 @@ class SingleProcessPubSub {
         await eventEmitter.emit(topic, data);
     }
     async unsubscribe(topic, subscriberId) {
-        // get subscriber function from id
-        const subscriber = this.subscribers[subscriberId];
-        await eventEmitter.removeListener(topic, subscriber);
-        // remove subscriber from subscribers
-        delete this.subscribers[subscriberId];
+        try {
+            // get subscriber function from id
+            const subscriber = this.subscribers[subscriberId];
+            if (subscriber) {
+                await eventEmitter.removeListener(topic, subscriber);
+            }
+            // remove subscriber from subscribers
+            delete this.subscribers[subscriberId];
+        }
+        catch (err) {
+            console.warn("error unsubscribing from topic", topic, err);
+        }
     }
 }
 

packages/core/src/server/pubsub/singleProcessPubSub.ts

@@ -26,10 +26,17 @@ export class SingleProcessPubSub implements Subscriber, Publisher {
   }
 
   public async unsubscribe(topic: string, subscriberId: string) {
-    // get subscriber function from id
-    const subscriber = this.subscribers[subscriberId];
-    await eventEmitter.removeListener(topic, subscriber);
-    // remove subscriber from subscribers
-    delete this.subscribers[subscriberId];
+    try {
+      // get subscriber function from id
+      const subscriber = this.subscribers[subscriberId];
+
+      if (subscriber) {
+        await eventEmitter.removeListener(topic, subscriber);
+      }
+      // remove subscriber from subscribers
+      delete this.subscribers[subscriberId];
+    } catch (err) {
+      console.warn("error unsubscribing from topic", topic, err);
+    }
   }
 }