Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throttleHost is not array in ExternalRateLimit #633

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

reaver-flomesh
Copy link
Collaborator

Description:

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)?

@reaver-flomesh reaver-flomesh added area/gateway-api Task/Issue related to GatewayAPI change/go Pull requests that update Go code kind/bug Something isn't working priority/P1 P1 priority size/XS 1 day labels Jan 14, 2025
@reaver-flomesh reaver-flomesh added this to the v1.5.0 milestone Jan 14, 2025
@reaver-flomesh reaver-flomesh self-assigned this Jan 14, 2025
Copy link
Contributor

mergify bot commented Jan 14, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(\[wip\]|\[backport\]|\[cherry-pick\])?( )?(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 Enforce verified commits

Wonderful, this rule succeeded.

Make sure that we have verified commits

  • #commits-unverified = 0

🟢 Enforce linear history

Wonderful, this rule succeeded.

Make sure that we have a linear history, no merge commits are allowed

  • linear-history

Signed-off-by: Lin Yang <[email protected]>
Signed-off-by: Lin Yang <[email protected]>
@reaver-flomesh
Copy link
Collaborator Author

/lgtm

@github-actions github-actions bot added ok-to-merge The PR can be merged squash Auto squash and merge the PR labels Jan 14, 2025
@mergify mergify bot merged commit 202805c into main Jan 14, 2025
31 checks passed
@mergify mergify bot deleted the hotfix/external-ratelimit branch January 14, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Task/Issue related to GatewayAPI change/go Pull requests that update Go code kind/bug Something isn't working ok-to-merge The PR can be merged priority/P1 P1 priority size/XS 1 day squash Auto squash and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants