Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ignore mesh services without ready endpoints. #623

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Jan 7, 2025

Description:
ignore mesh services without ready endpoints.

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [X]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? bo

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

Copy link
Contributor

mergify bot commented Jan 7, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(\[wip\]|\[backport\]|\[cherry-pick\])?( )?(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 Enforce verified commits

Wonderful, this rule succeeded.

Make sure that we have verified commits

  • #commits-unverified = 0

🟢 Enforce linear history

Wonderful, this rule succeeded.

Make sure that we have a linear history, no merge commits are allowed

  • linear-history

@reaver-flomesh reaver-flomesh added area/service-mesh Task/Issue related to Service Mesh change/go Pull requests that update Go code kind/enhancement New feature or request priority/P1 P1 priority size/XS 1 day labels Jan 7, 2025
@reaver-flomesh reaver-flomesh added this to the v1.5.0 milestone Jan 7, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.5@2a59b50). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/catalog/outbound_traffic_policies.go 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.5     #623   +/-   ##
===============================================
  Coverage                ?   14.75%           
===============================================
  Files                   ?      871           
  Lines                   ?    63512           
  Branches                ?        0           
===============================================
  Hits                    ?     9369           
  Misses                  ?    53959           
  Partials                ?      184           
Flag Coverage Δ
unittests 14.75% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh
Copy link
Collaborator

/lgtm

@github-actions github-actions bot added ok-to-merge The PR can be merged squash Auto squash and merge the PR labels Jan 7, 2025
@mergify mergify bot merged commit 8b728cd into flomesh-io:release/v1.5 Jan 7, 2025
29 checks passed
@cybwan cybwan deleted the release/v1.5.0-alpha.12 branch January 7, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Task/Issue related to Service Mesh change/go Pull requests that update Go code kind/enhancement New feature or request ok-to-merge The PR can be merged priority/P1 P1 priority size/XS 1 day squash Auto squash and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants