Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slow starting warm-up feature #618

Closed

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Jan 6, 2025

Description:
support slow starting warm-up feature

Testing done:
Done

Affected area:

Functional Area
New Functionality [X]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

Copy link
Contributor

mergify bot commented Jan 6, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(\[wip\]|\[backport\]|\[cherry-pick\])?( )?(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 Enforce verified commits

Wonderful, this rule succeeded.

Make sure that we have verified commits

  • #commits-unverified = 0

🟢 Enforce linear history

Wonderful, this rule succeeded.

Make sure that we have a linear history, no merge commits are allowed

  • linear-history

@reaver-flomesh reaver-flomesh added area/service-mesh Task/Issue related to Service Mesh change/go Pull requests that update Go code kind/enhancement New feature or request priority/P1 P1 priority size/S 3 days labels Jan 6, 2025
@reaver-flomesh reaver-flomesh added this to the v1.5.0 milestone Jan 6, 2025
@reaver-flomesh reaver-flomesh linked an issue Jan 6, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.21739% with 312 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.5@2cf92eb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...d/typed/policy/v1alpha1/fake/fake_trafficwarmup.go 15.58% 62 Missing and 3 partials ⚠️
pkg/catalog/trafficwarmup.go 0.00% 55 Missing ⚠️
pkg/apis/policy/v1alpha1/zz_generated.deepcopy.go 0.00% 52 Missing ⚠️
pkg/sidecar/v1/providers/pipy/repo/policy.go 0.00% 31 Missing ⚠️
pkg/apis/config/v1alpha3/zz_generated.deepcopy.go 18.51% 19 Missing and 3 partials ⚠️
pkg/apis/config/v1alpha3/mesh_config.go 0.00% 21 Missing ⚠️
pkg/policy/client.go 56.75% 16 Missing ⚠️
.../externalversions/policy/v1alpha1/trafficwarmup.go 52.38% 8 Missing and 2 partials ⚠️
...t/versioned/typed/policy/v1alpha1/trafficwarmup.go 0.00% 9 Missing ⚠️
pkg/catalog/mock_catalog_generated.go 0.00% 8 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.5     #618   +/-   ##
===============================================
  Coverage                ?   14.75%           
===============================================
  Files                   ?      871           
  Lines                   ?    63498           
  Branches                ?        0           
===============================================
  Hits                    ?     9368           
  Misses                  ?    53946           
  Partials                ?      184           
Flag Coverage Δ
unittests 14.75% <15.21%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cybwan cybwan closed this Jan 6, 2025
@cybwan cybwan deleted the release/v1.5.0-alpha.11 branch January 6, 2025 15:17
@reaver-flomesh reaver-flomesh removed this from the v1.5.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Task/Issue related to Service Mesh change/go Pull requests that update Go code kind/enhancement New feature or request priority/P1 P1 priority size/S 3 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support slow starting warm-up feature
3 participants