Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: via gateway for vm #613

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Jan 3, 2025

Description:
fix via gateway for vm

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

Copy link
Contributor

mergify bot commented Jan 3, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(\[wip\]|\[backport\]|\[cherry-pick\])?( )?(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 Enforce verified commits

Wonderful, this rule succeeded.

Make sure that we have verified commits

  • #commits-unverified = 0

🟢 Enforce linear history

Wonderful, this rule succeeded.

Make sure that we have a linear history, no merge commits are allowed

  • linear-history

@reaver-flomesh reaver-flomesh added area/connector Task/Issue related to cloud connector change/go Pull requests that update Go code kind/bug Something isn't working priority/P1 P1 priority size/XS 1 day labels Jan 3, 2025
@reaver-flomesh reaver-flomesh added this to the v1.5.0 milestone Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.5@e2575c0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sidecar/v1/providers/pipy/repo/util.go 0.00% 17 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.5     #613   +/-   ##
===============================================
  Coverage                ?   14.73%           
===============================================
  Files                   ?      866           
  Lines                   ?    63160           
  Branches                ?        0           
===============================================
  Hits                    ?     9304           
  Misses                  ?    53680           
  Partials                ?      176           
Flag Coverage Δ
unittests 14.73% <5.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh force-pushed the release/v1.5.0-alpha.10 branch from ac0257f to b989234 Compare January 3, 2025 13:19
Copy link
Contributor

mergify bot commented Jan 3, 2025

❗❗❗
All commits in this PR must be signed off.
Please sign all commits by:

git rebase HEAD~2 --signoff
git push --force-with-lease origin release/v1.5.0-alpha.10

@reaver-flomesh reaver-flomesh force-pushed the release/v1.5.0-alpha.10 branch from b989234 to c23371c Compare January 3, 2025 14:45
cybwan added 2 commits January 3, 2025 22:47
Signed-off-by: Cybwan <[email protected]>
Signed-off-by: Lin Yang <[email protected]>
Signed-off-by: Cybwan <[email protected]>
Signed-off-by: Lin Yang <[email protected]>
@reaver-flomesh reaver-flomesh force-pushed the release/v1.5.0-alpha.10 branch from c23371c to 66ae256 Compare January 3, 2025 14:47
@reaver-flomesh
Copy link
Collaborator

/lgtm

@github-actions github-actions bot added ok-to-merge The PR can be merged squash Auto squash and merge the PR labels Jan 3, 2025
@mergify mergify bot merged commit 2cf92eb into flomesh-io:release/v1.5 Jan 3, 2025
27 checks passed
@cybwan cybwan deleted the release/v1.5.0-alpha.10 branch January 4, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connector Task/Issue related to cloud connector change/go Pull requests that update Go code kind/bug Something isn't working ok-to-merge The PR can be merged priority/P1 P1 priority size/XS 1 day squash Auto squash and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants