Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: virtual machine monitor. #602

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Dec 31, 2024

Description:
fix virtual machine monitor.

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

Copy link
Contributor

mergify bot commented Dec 31, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(\[wip\]|\[backport\]|\[cherry-pick\])?( )?(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 Enforce verified commits

Wonderful, this rule succeeded.

Make sure that we have verified commits

  • #commits-unverified = 0

🟢 Enforce linear history

Wonderful, this rule succeeded.

Make sure that we have a linear history, no merge commits are allowed

  • linear-history

@reaver-flomesh reaver-flomesh added area/connector Task/Issue related to cloud connector change/go Pull requests that update Go code kind/bug Something isn't working priority/P1 P1 priority size/S 3 days cherry-pick/main Cherry-pick the PR to main branch labels Dec 31, 2024
@reaver-flomesh reaver-flomesh added this to the v1.4.17 milestone Dec 31, 2024
@reaver-flomesh reaver-flomesh force-pushed the release/v1.4.17-alpha.1 branch 2 times, most recently from 97977d1 to ef33aa7 Compare December 31, 2024 07:29
Copy link
Contributor

mergify bot commented Dec 31, 2024

❗❗❗
All commits in this PR must be signed off.
Please sign all commits by:

git rebase HEAD~1 --signoff
git push --force-with-lease origin release/v1.4.17-alpha.1

@reaver-flomesh reaver-flomesh force-pushed the release/v1.4.17-alpha.1 branch 3 times, most recently from 1c4d408 to 470077c Compare December 31, 2024 07:34
Signed-off-by: Cybwan <[email protected]>
Signed-off-by: Lin Yang <[email protected]>
@reaver-flomesh reaver-flomesh force-pushed the release/v1.4.17-alpha.1 branch from 470077c to 92d1019 Compare December 31, 2024 07:43
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.4@9a19c3e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/k8s/client.go 12.50% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.4     #602   +/-   ##
===============================================
  Coverage                ?   14.16%           
===============================================
  Files                   ?      820           
  Lines                   ?    65280           
  Branches                ?        0           
===============================================
  Hits                    ?     9245           
  Misses                  ?    55860           
  Partials                ?      175           
Flag Coverage Δ
unittests 14.16% <12.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh
Copy link
Collaborator

/lgtm

@github-actions github-actions bot added ok-to-merge The PR can be merged squash Auto squash and merge the PR labels Dec 31, 2024
@mergify mergify bot merged commit 59b8f26 into flomesh-io:release/v1.4 Dec 31, 2024
27 checks passed
mergify bot pushed a commit that referenced this pull request Dec 31, 2024
fix virtual machine monitor.

Signed-off-by: Cybwan <[email protected]>
Signed-off-by: Lin Yang <[email protected]>
(cherry picked from commit 59b8f26)
reaver-flomesh pushed a commit that referenced this pull request Dec 31, 2024
fix virtual machine monitor.

Signed-off-by: Cybwan <[email protected]>
Signed-off-by: Lin Yang <[email protected]>
(cherry picked from commit 59b8f26)
Signed-off-by: Lin Yang <[email protected]>
@cybwan cybwan deleted the release/v1.4.17-alpha.1 branch December 31, 2024 10:40
mergify bot added a commit that referenced this pull request Dec 31, 2024
fix: virtual machine monitor. (#602)

fix virtual machine monitor.



(cherry picked from commit 59b8f26)

Signed-off-by: Cybwan <[email protected]>
Signed-off-by: Lin Yang <[email protected]>
Co-authored-by: Cybwan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connector Task/Issue related to cloud connector change/go Pull requests that update Go code cherry-pick/main Cherry-pick the PR to main branch kind/bug Something isn't working ok-to-merge The PR can be merged priority/P1 P1 priority size/S 3 days squash Auto squash and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants