Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HoldApplicationUntilProxyStarts feature. #575

Merged

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Dec 26, 2024

Description:
fix HoldApplicationUntilProxyStarts feature.

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.5@73241bd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/messaging/broker.go 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.5     #575   +/-   ##
===============================================
  Coverage                ?   14.95%           
===============================================
  Files                   ?      841           
  Lines                   ?    62177           
  Branches                ?        0           
===============================================
  Hits                    ?     9297           
  Misses                  ?    52704           
  Partials                ?      176           
Flag Coverage Δ
unittests 14.95% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh added area/service-mesh Task/Issue related to Service Mesh change/go Pull requests that update Go code kind/bug Something isn't working priority/P0 P0 priority, highest size/XS 1 day labels Dec 26, 2024
@reaver-flomesh reaver-flomesh added this to the v1.5.0 milestone Dec 26, 2024
Copy link

✅ PR Title Formatted Correctly

The title of this PR has been updated to match the correct format. Thank you!

@reaver-flomesh reaver-flomesh merged commit 8514ebe into flomesh-io:release/v1.5 Dec 26, 2024
34 checks passed
@cybwan cybwan deleted the release/v1.5.0-alpha.5 branch December 26, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Task/Issue related to Service Mesh change/go Pull requests that update Go code kind/bug Something isn't working priority/P0 P0 priority, highest size/XS 1 day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants