Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local dns proxy. #487

Merged

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Nov 29, 2024

Description:
fix local dns proxy.

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

Signed-off-by: Cybwan <[email protected]>
@github-actions github-actions bot added the title needs formatting PR title is not in a valid format label Nov 29, 2024
@reaver-flomesh reaver-flomesh added this to the v1.4.13 milestone Nov 29, 2024
@reaver-flomesh reaver-flomesh changed the title fix local dns proxy. fix: local dns proxy. Nov 29, 2024
@github-actions github-actions bot removed the title needs formatting PR title is not in a valid format label Nov 29, 2024
Copy link

✅ PR Title Formatted Correctly

The title of this PR has been updated to match the correct format. Thank you!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.4@25451af). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/dns/handler.go 0.00% 44 Missing ⚠️
pkg/dns/resolver.go 0.00% 2 Missing ⚠️
pkg/dns/server.go 0.00% 2 Missing ⚠️
...kg/sidecar/providers/pipy/driver/pipy_container.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.4     #487   +/-   ##
===============================================
  Coverage                ?   14.18%           
===============================================
  Files                   ?      820           
  Lines                   ?    65249           
  Branches                ?        0           
===============================================
  Hits                    ?     9256           
  Misses                  ?    55818           
  Partials                ?      175           
Flag Coverage Δ
unittests 14.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh merged commit a2a08b2 into flomesh-io:release/v1.4 Nov 30, 2024
27 checks passed
reaver-flomesh pushed a commit that referenced this pull request Nov 30, 2024
reaver-flomesh added a commit that referenced this pull request Nov 30, 2024
@cybwan cybwan deleted the release/v1.4.13-alpha.1 branch November 30, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants