Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] ci: adjust the regex of validating PR title (#479) #480

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

reaver-flomesh
Copy link
Collaborator

  • ci: adjust the regex of validating PR title

  • docs: update comment of invalid PR title


Description:

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)?

* ci: adjust the regex of validating PR title

Signed-off-by: Lin Yang <[email protected]>

* docs: update comment of invalid PR title

Signed-off-by: Lin Yang <[email protected]>

---------

Signed-off-by: Lin Yang <[email protected]>
@reaver-flomesh reaver-flomesh added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Nov 26, 2024
@reaver-flomesh reaver-flomesh added this to the v1.4.12 milestone Nov 26, 2024
@reaver-flomesh reaver-flomesh self-assigned this Nov 26, 2024
@github-actions github-actions bot added the title needs formatting PR title is not in a valid format label Nov 26, 2024
Copy link

🚨 PR Title Needs Formatting

The title of this PR needs to be formatted correctly.
Please update the title to match the format type: description AB#xxx. Examples:

  • fix: fix typo in README.md AB#123
  • chore: update dependencies AB#456
  • feat: add new feature AB#789
  • chore: fixing build pipeline - no AB reference

For more details, please refer to the Conventional Commits Specification
and the PR Title Configuration File.

@reaver-flomesh reaver-flomesh removed the title needs formatting PR title is not in a valid format label Nov 26, 2024
@reaver-flomesh reaver-flomesh merged commit 7857365 into release/v1.4 Nov 26, 2024
26 checks passed
@reaver-flomesh reaver-flomesh deleted the feature/backport-479 branch November 26, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant