Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local dns proxy. #467

Merged

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Nov 22, 2024

Description:
fix local dns proxy.

Testing done:
Done

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.4@0b44bf5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/dns/handler.go 0.00% 34 Missing ⚠️
pkg/k8s/mock_controller_generated.go 0.00% 8 Missing ⚠️
pkg/k8s/client.go 0.00% 6 Missing ⚠️
pkg/dns/resolver.go 0.00% 2 Missing ⚠️
pkg/dns/server.go 0.00% 2 Missing ⚠️
pkg/sidecar/providers/pipy/repo/jobs.go 0.00% 2 Missing ⚠️
cmd/fsm-controller/fsm-controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.4     #467   +/-   ##
===============================================
  Coverage                ?   14.19%           
===============================================
  Files                   ?      820           
  Lines                   ?    65225           
  Branches                ?        0           
===============================================
  Hits                    ?     9256           
  Misses                  ?    55794           
  Partials                ?      175           
Flag Coverage Δ
unittests 14.19% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@reaver-flomesh reaver-flomesh added the enhancement New feature or request label Nov 22, 2024
@reaver-flomesh reaver-flomesh added this to the v1.4.12 milestone Nov 22, 2024
@reaver-flomesh reaver-flomesh merged commit a624743 into flomesh-io:release/v1.4 Nov 22, 2024
24 checks passed
@cybwan cybwan deleted the release/v1.4.12-alpha.1 branch November 22, 2024 12:17
reaver-flomesh pushed a commit that referenced this pull request Nov 22, 2024
reaver-flomesh added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants