Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip upload brew formula if no PAT #464

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

reaver-flomesh
Copy link
Collaborator

Description:

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)?

@reaver-flomesh reaver-flomesh added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Nov 21, 2024
@reaver-flomesh reaver-flomesh added this to the v1.4.11 milestone Nov 21, 2024
@reaver-flomesh reaver-flomesh self-assigned this Nov 21, 2024
@reaver-flomesh reaver-flomesh merged commit 0b44bf5 into release/v1.4 Nov 21, 2024
43 of 44 checks passed
@reaver-flomesh reaver-flomesh deleted the feature/skip-upload branch November 21, 2024 05:09
reaver-flomesh added a commit that referenced this pull request Nov 21, 2024
* feat: skip upload brew formula if no PAT

Signed-off-by: Lin Yang <[email protected]>

* feat: skip upload brew formula if no PAT

Signed-off-by: Lin Yang <[email protected]>

---------

Signed-off-by: Lin Yang <[email protected]>
reaver-flomesh added a commit that referenced this pull request Nov 21, 2024
* feat: skip upload brew formula if no PAT



* feat: skip upload brew formula if no PAT



---------

Signed-off-by: Lin Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant