-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High, constant CPU usage in Firefox #973
Comments
Can confirm the issue with Firefox 92 with Nextcloud. |
Floccus may be caught in an infinite loop :/ Does it help to disable the addon and re-enable it? Triggering a sync from scratch in the settings (with backup beforehand)? |
Disabling and re-enabling doesn't help. That was how I was able to narrow down the add-on as being the source of the problem, unfortunately. I haven't tried blowing my settings or anything like that. If there's a way for me to help you debug it, please let me know. I don't have experience with web extensions, but I have general development experience, including writing NPAPI plugins. |
This comment has been minimized.
This comment has been minimized.
Ahh, good ol' stalebot. |
Here's how you can debug: Firefox
Chrome
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I get this in the console. Hope it helps. Just keeping the addon enable, consumes a lot of RAM, making the whole system unusable. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Issue confirmed with :
|
|
Some more information :
With the new Firefox profile, the behaviour is slightly different :
|
Investigating this, I found that the indeterminate loading bar animation at the top of a syncing account card causes a huge CPU load.
I couldn't reproduce this, so far, but will investigate further. |
Perhaps providing a test version without the loading bar animation (and the sync animation ?) may shed some proverbial light whether there is a correlation with the other above reported CPU usage issues ? |
How do you know that the sync is successful or even done, if the UI still says loading? |
Causes unwarranted CPU load see #973
By examing the Apache/httpd (Nextcloud) access logs :
|
This only means that the current server state was fetched, not that sync is finished. |
Indeed, it seems the sync process does not finish (lockfile is not removed) :
|
I may at long last have found a reason for this. Or at least identified one performance leak. Let's see if the next release improves the situation here. |
I have bad news - upgraded to 4.12.0 and checked if problem still occurs. As soon as I enable floccus plugin (4.12.0 with auto-sync turned off) - trace log is getting bombed by huge queries (see log below). I'm not running any sync, floccus debug logs have no new entries. ( plugin disabled) ( plugin enabled from firefox UI somewhere here) 2022-03-22 19:59:26.367696 UTC - [Parent 3832: Permission]: D/mozStorage TRACE_TIME on 9ee1d9c0: 20ms |
one more remark related to my previous comment - I have cleared my whole browsing history so only bookmarks managed by floccus are kept within profile:
I'm surprised by still huge size of favicons, but I assume it should not impact synchronization queries |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ping |
@cracket Thanks for sharing these, should be quite useful in tackling this! |
Can you try the latest release and see if that fixes things? |
Ping @cracket |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We should probably keep this open until the issue is confirmed to be fixed. |
@nirvdrum I'm happy to collaborate and troubleshoot and work on fixes, but I need feedback. If nobody tests the latest release I'm closing the issue. |
Sorry for delay, but I didnt have access to slow hardware. I've checked version 4.13.1 and there are some good news - namely there were only 5 huge queries executed taking 45 secs each. After that - there are no huge queries looping for ever while firefox is idle. I have no proof these queries origin from flooccus and not firefox itself, but I attach some logs for you:
|
Nice, I have indeed added a cache for the bookmarks full tree query which should result in a fixed number of long running queries on startup and no long running queries during runtime of the browser as you report. This means we've finally found the performance sink! If there was a different way to find out the id of the root folder I'd use it, but as of yet, to my knowledge, there is not. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Describe the bug
Ever since upgrading from Firefox 91 to 92, I've noticed very high CPU usage of the browser. I ran in troubleshooting mode and the browser ran fine, indicating it was likely a problem with an add-on. I've since then gone through every add-on I have installed and enabled them one by one, isolating the problematic add-on. Floccus appears to be the source of the issue. I did verify disabling the extension reduces CPU consumption (requiring a browser restart, unfortunately). Enabling the add-on immediately jumps the CPU to 100 - 250%.
It may be that the Firefox upgrade was incidental and the issue was actually due to a Floccus upgrade. I have Floccus automatically update, so I don't know what I may have been running previously.
To Reproduce
Steps to reproduce the behavior:
The CPU usage climbs immediately after enabling the add-on. I use WebDAV synchronization. The Floccus panel shows that it is constantly trying to synchronize, with a "normal sync" process.
Expected behavior
I'd expect Floccus to perform synchronization in the background with bursty CPU usage. Instead, it keeps at least one hardware thread fully utilized.
Desktop
(please complete the following information)
Server
I use Fastmail as my WebDAV provider. I do not have any insights into what their deployment environment is.
Debug log
Unfortunately, I don't see the the link to download the debug log. My lower-right corner is a link to "Secure your Credentials". I've looked for it on the add-on preferences page, but can't see anything there either.
Additional context
The add-on is unresponsive when clicking the "Cancel Sync" button.
The text was updated successfully, but these errors were encountered: