fix: remove default namespace as a requirement to list namespaces #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Flipt with authz requires user to have read access to default namespace in order to list the namespaces. This edge case ninja'd its way into the code like a shadow in the night, but it’s time for this stealthy PR troublemaker to find another codebase to haunt! Side effect 1: the deps has been updated and the code should be regenerated. Side effect 2: the tests are broken with PR #3595 in RPC and they are not run in CI. Signed-off-by: Roman Dmytrenko <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3711 +/- ##
=======================================
Coverage 64.56% 64.56%
=======================================
Files 170 170
Lines 17140 17140
=======================================
Hits 11067 11067
Misses 5384 5384
Partials 689 689
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Flipt with authz requires user to have read access to default
namespace in order to list the namespaces. This edge case ninja'd its way
into the code like a shadow in the night, but it’s time for this stealthy
PR troublemaker to find another codebase to haunt!
Side effect 1: the deps has been updated and the code should be regenerated.
Side effect 2: the tests are broken with PR #3595 in RPC and they are not run
in CI.
related to #3692 #3688